http_server: document new ingress config and metrics#2546
http_server: document new ingress config and metrics#2546
Conversation
Signed-off-by: Eduardo Silva <edsiper@gmail.com>
Signed-off-by: Eduardo Silva <edsiper@gmail.com>
Signed-off-by: Eduardo Silva <edsiper@gmail.com>
📝 WalkthroughWalkthroughDocumentation updates across multiple Fluent Bit configuration files adding two new HTTP listener configuration keys ( Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related issues
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (5)
pipeline/inputs/elasticsearch.md (1)
13-13: Consider alternative phrasing for "below".Similar to other files in this PR, consider using "This table includes both:" instead of "The table below includes both:" to avoid directional language.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@pipeline/inputs/elasticsearch.md` at line 13, Replace the phrase "The table below includes both:" with directional-neutral wording; locate the exact string "The table below includes both:" in pipeline/inputs/elasticsearch.md and change it to "This table includes both:" so phrasing matches other files and avoids directional language.pipeline/inputs/opentelemetry.md (1)
17-17: Consider alternative phrasing for "below".To maintain consistency with style guidelines and improve accessibility, consider "This table includes both:" instead of "The table below includes both:".
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@pipeline/inputs/opentelemetry.md` at line 17, Replace the phrase "The table below includes both:" with "This table includes both:" in the opentelemetry.md content so wording is consistent with style guidelines and improves accessibility; search for the exact string "The table below includes both:" and update it to the suggested alternative.pipeline/inputs/prometheus-remote-write.md (1)
15-15: Consider alternative phrasing for "below".The static analysis tool flags the use of "below" as directional language. While this is a minor style issue, consider alternatives like "The following table includes both:" or simply "This table includes both:" for improved accessibility and clarity.
✏️ Suggested alternative phrasing
-The table below includes both: +This table includes both:🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@pipeline/inputs/prometheus-remote-write.md` at line 15, Replace the directional phrasing "The table below includes both:" with a non-directional alternative to improve accessibility—e.g., change the sentence to "The following table includes both:" or "This table includes both:" in the content where the string "The table below includes both:" appears so the copy no longer relies on spatial language.pipeline/inputs/splunk.md (1)
13-13: Consider alternative phrasing for "below".For consistency with style guidelines, consider "This table includes both:" instead of "The table below includes both:".
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@pipeline/inputs/splunk.md` at line 13, Replace the phrase "The table below includes both:" with the preferred phrasing "This table includes both:" — locate the sentence containing the exact string "The table below includes both:" in pipeline/inputs/splunk.md and update it to "This table includes both:" to match style guidelines.pipeline/inputs/http.md (1)
12-12: Consider alternative phrasing for "below".To align with style guidelines and improve accessibility, consider "This table includes both:" instead of "The table below includes both:".
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@pipeline/inputs/http.md` at line 12, Replace the wording "The table below includes both:" with "This table includes both:" in the Markdown content where that sentence appears (update the specific line that currently reads "The table below includes both:" to the new phrasing and adjust any other identical occurrences to match the style guideline).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@pipeline/inputs/elasticsearch.md`:
- Line 13: Replace the phrase "The table below includes both:" with
directional-neutral wording; locate the exact string "The table below includes
both:" in pipeline/inputs/elasticsearch.md and change it to "This table includes
both:" so phrasing matches other files and avoids directional language.
In `@pipeline/inputs/http.md`:
- Line 12: Replace the wording "The table below includes both:" with "This table
includes both:" in the Markdown content where that sentence appears (update the
specific line that currently reads "The table below includes both:" to the new
phrasing and adjust any other identical occurrences to match the style
guideline).
In `@pipeline/inputs/opentelemetry.md`:
- Line 17: Replace the phrase "The table below includes both:" with "This table
includes both:" in the opentelemetry.md content so wording is consistent with
style guidelines and improves accessibility; search for the exact string "The
table below includes both:" and update it to the suggested alternative.
In `@pipeline/inputs/prometheus-remote-write.md`:
- Line 15: Replace the directional phrasing "The table below includes both:"
with a non-directional alternative to improve accessibility—e.g., change the
sentence to "The following table includes both:" or "This table includes both:"
in the content where the string "The table below includes both:" appears so the
copy no longer relies on spatial language.
In `@pipeline/inputs/splunk.md`:
- Line 13: Replace the phrase "The table below includes both:" with the
preferred phrasing "This table includes both:" — locate the sentence containing
the exact string "The table below includes both:" in pipeline/inputs/splunk.md
and update it to "This table includes both:" to match style guidelines.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 78428e65-d9cc-4ad7-af4a-3843aa968a36
📒 Files selected for processing (10)
administration/configuring-fluent-bit/yaml/pipeline-section.mdadministration/configuring-fluent-bit/yaml/service-section.mdadministration/monitoring.mdinstallation/upgrade-notes.mdinstallation/whats-new-in-fluent-bit-v5.0.mdpipeline/inputs/elasticsearch.mdpipeline/inputs/http.mdpipeline/inputs/opentelemetry.mdpipeline/inputs/prometheus-remote-write.mdpipeline/inputs/splunk.md
documents changes from: fluent/fluent-bit#11704
This PR documents the new deferred ingress queue settings and metrics for HTTP-based inputs.
It adds the new shared HTTP listener settings:
http_server.ingress_queue_event_limithttp_server.ingress_queue_byte_limitIt also documents the new
/api/v2/metrics/prometheusmetrics:fluentbit_input_http_server_ingress_queue_pending_eventsfluentbit_input_http_server_ingress_queue_pending_bytesfluentbit_input_http_server_ingress_queue_busy_totalScope
httpsplunkelasticsearchopentelemetryprometheus_remote_writeReader experience improvements
The plugin pages now make it explicit that their configuration tables include both:
http_server.*listener settingsThey also link back to the shared listener section so new users can understand which options are common across inputs and when the ingress queue settings apply.
Notes
The ingress queue settings and metrics apply only when
http_server.workers > 1.Summary by CodeRabbit