pipeline: outputs: cloudwatch: Add StorageResolution Support#1691
Open
devin-andrenam wants to merge 4 commits intofluent:masterfrom
Open
pipeline: outputs: cloudwatch: Add StorageResolution Support#1691devin-andrenam wants to merge 4 commits intofluent:masterfrom
devin-andrenam wants to merge 4 commits intofluent:masterfrom
Conversation
Signed-off-by: Devin Stafford <devin@andrenam.com>
dffc58f to
f5dff74
Compare
3 tasks
esmerel
approved these changes
May 29, 2025
Contributor
esmerel
left a comment
There was a problem hiding this comment.
Minor stylistic change. A @fluent/fluent-bit-maintainers should doublecheck the definition for technical accuracy, but I'm otherwise ok with this.
Signed-off-by: Lynette Miles <6818907+esmerel@users.noreply.github.com>
Collaborator
|
@devin-andrenam while waiting on the code PR changes fluent/fluent-bit#10398 you need to make, would you please fix the conflicts here so I'm ready to merge your docs update when we can? |
Signed-off-by: Lynette Miles <6818907+esmerel@users.noreply.github.com>
Contributor
|
Conflict was due to formatting changes for style. I reverified so the submitter doesn't need to. |
Contributor
|
There are on changes? |
Signed-off-by: Lynette Miles <6818907+esmerel@users.noreply.github.com>
Contributor
|
Appears I overwrote the change fixing the conflict, I corrected it. I was afraid I'd done that at least once. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation update in association with according PR to fluent bit.