fix(fetcher): limit fetch chunks#1346
Open
puneetdixit200 wants to merge 1 commit into
Open
Conversation
floatpanebot
previously requested changes
May 22, 2026
Member
floatpanebot
left a comment
floatpanebot
left a comment
There was a problem hiding this comment.
Hi @puneetdixit200! Please fix the following issues with your PR:
- Title: Is too long (40 characters). The PR title must be strictly under 40 characters.
- Body: Missing the
## What?or## Why?headings required by the PR template.
floatpanebot
added
area/fetcher
puneetdixit200
changed the title
floatpanebot
dismissed
their stale review
Formatting issues have been resolved. Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
FetchMailboxEmailslimit=5fetches only96:100from a 100-message mailboxWhy?
When callers request a small page, the fetcher should not over-fetch 50 messages before filtering and trimming. This keeps IMAP bandwidth and server load proportional to the requested limit.
Fixes #1106
Tests
GOMODCACHE=/tmp/matcha-1106-gomodcache GOCACHE=/tmp/matcha-1106-gocache go test ./fetcher -run TestFetchMailboxEmailsUsesRequestedLimitForSmallFetchChunks -count=1GOMODCACHE=/tmp/matcha-1106-gomodcache GOCACHE=/tmp/matcha-1106-gocache make testGOMODCACHE=/tmp/matcha-1106-gomodcache GOCACHE=/tmp/matcha-1106-gocache make lintgit diff --check