Skip to content

fix: handle os.Remove and os.Chmod errors in daemon startup#1335

Open
MD-Mushfiqur123 wants to merge 1 commit into
floatpane:masterfrom
MD-Mushfiqur123:fix/unchecked-daemon-errors
Open

fix: handle os.Remove and os.Chmod errors in daemon startup#1335
MD-Mushfiqur123 wants to merge 1 commit into
floatpane:masterfrom
MD-Mushfiqur123:fix/unchecked-daemon-errors

Conversation

@MD-Mushfiqur123
Copy link
Copy Markdown

Fixes #714 and #719. Check os.Remove error (skip IsNotExist) for stale socket cleanup, and check os.Chmod error when setting socket permissions.

@MD-Mushfiqur123 MD-Mushfiqur123 requested a review from a team as a code owner May 22, 2026 06:06
Copy link
Copy Markdown
Member

@floatpanebot floatpanebot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @MD-Mushfiqur123! Please fix the following issues with your PR:

  • Title: Is too long (59 characters). The PR title must be strictly under 40 characters.
  • Body: Missing the ## What? or ## Why? headings required by the PR template.

@floatpanebot floatpanebot added bug Something isn't working chore Maintenance, refactor, cleanup area/daemon Daemon / RPC size/XS Diff: 0–10 lines and removed bug Something isn't working chore Maintenance, refactor, cleanup area/daemon Daemon / RPC labels May 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working chore Maintenance, refactor, cleanup size/XS Diff: 0–10 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: Unchecked os.Chmod() error leaves daemon socket permissions vulnerable

2 participants