fix(pgp): check packet length writes#1324
Closed
resolvicomai wants to merge 1 commit into
Closed
Conversation
floatpanebot
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Return and propagate write errors from
writeNewFormatLength, and check the surrounding signature packet writes while building YubiKey OpenPGP signature packets.Why?
Closes #621. The length helper previously wrote into the packet buffer without surfacing writer failures, which could silently produce an invalid packet if the writer failed. Added tests for the OpenPGP new-format length encodings and for write-error propagation.
Tests:
go test ./pgp;go test ./...;make lint;git diff --check