fix(flet-audio): replaying Audio after completion under ReleaseMode.RELEASE raises TimeoutException#6538
Open
ndonkoHenri wants to merge 3 commits into
Open
fix(flet-audio): replaying Audio after completion under ReleaseMode.RELEASE raises TimeoutException#6538ndonkoHenri wants to merge 3 commits into
Audio after completion under ReleaseMode.RELEASE raises TimeoutException#6538ndonkoHenri wants to merge 3 commits into
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes flet-audio replay behavior after audio completion in the default release mode by re-preparing the native audio source before replaying or seeking.
Changes:
- Extracts audio source setup into
_applySource()and reuses it after completed playback underReleaseMode.release. - Updates
ReleaseModedocumentation to clarify resource/replay behavior. - Adds a changelog entry and clarifies
Audio.play()default start position.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
sdk/python/packages/flet-audio/src/flutter/flet_audio/lib/src/audio.dart |
Re-applies the source before replay/seek after completion in release mode. |
sdk/python/packages/flet-audio/src/flet_audio/types.py |
Expands ReleaseMode behavior documentation. |
sdk/python/packages/flet-audio/src/flet_audio/audio.py |
Clarifies play(position) defaults to the beginning. |
CHANGELOG.md |
Documents the audio replay timeout bug fix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Deploying flet-website-v2 with
|
| Latest commit: |
7b1b74f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://05ac1108.flet-website-v2.pages.dev |
| Branch Preview URL: | https://audio-fixes.flet-website-v2.pages.dev |
ndonkoHenri
changed the title
Audio after completion under ReleaseMode.RELEASE no longer raises TimeoutExceptionAudio after completion under ReleaseMode.RELEASE raises TimeoutException
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #6536
Summary by Sourcery
Ensure audio playback can be replayed safely after completion in release mode and improve clarity of release mode behavior.
Bug Fixes:
Enhancements: