Skip to content

gradle: Don't include missing resource URLs#520

Open
Newbytee wants to merge 1 commit into
flatpak:masterfrom
Newbytee:gradle-unavailable
Open

gradle: Don't include missing resource URLs#520
Newbytee wants to merge 1 commit into
flatpak:masterfrom
Newbytee:gradle-unavailable

Conversation

@Newbytee
Copy link
Copy Markdown
Contributor

If a given URL cannot be downloaded, Gradle will report it as the resource being missing. Respect this when finding URLs so we don't end up with URLs that are 404s.

Also make the URL list a set to facilitate this. It doesn't need to contain duplicates anyway.

@Newbytee Newbytee requested a review from hadess as a code owner March 26, 2026 21:44
If a given URL cannot be downloaded, Gradle will report it as the
resource being missing. Respect this when finding URLs so we don't
end up with URLs that are 404s.

Also make the URL list a set to facilitate this. It doesn't need to
contain duplicates anyway.

Signed-off-by: Stefan Hansson <newbyte@postmarketos.org>
@Newbytee Newbytee force-pushed the gradle-unavailable branch from 89f942c to 3185499 Compare March 26, 2026 21:52
@hadess
Copy link
Copy Markdown
Contributor

hadess commented May 14, 2026

If a given URL cannot be downloaded, Gradle will report it as the resource being missing. Respect this when finding URLs so we don't end up with URLs that are 404s.

Do you have a file on which we could test this?

@Newbytee
Copy link
Copy Markdown
Contributor Author

If a given URL cannot be downloaded, Gradle will report it as the resource being missing. Respect this when finding URLs so we don't end up with URLs that are 404s.

Do you have a file on which we could test this?

You mean like a log? I'm pretty sure this was the codebase I was working with at the time: https://github.com/zacharee/SamloaderKotlin

@hadess
Copy link
Copy Markdown
Contributor

hadess commented May 14, 2026

You mean like a log? I'm pretty sure this was the codebase I was working with at the time: https://github.com/zacharee/SamloaderKotlin

Yes, I'd need a log which I could parse and compare before/after this patch to see whether it's working correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants