Conversation
Member
dieppa
commented
Apr 14, 2026
dieppa
commented
- refactor: cloud api
- refactor: cloud api
dieppa
added a commit
that referenced
this pull request
Apr 15, 2026
Rename request/response/vo classes in flamingock-cloud-api so naming is consistent and unambiguous at call sites (no more bare TaskRequest / LockInfo that collide with internal types). Renames (request): - TaskRequest -> ChangeRequest - ClientSubmission -> ClientSubmissionRequest Renames (response): - TaskResponse -> ChangeResponse - ExecutionResponse -> ExecutionSummaryResponse - ExecutionFullResponse -> ExecutionDetailResponse - LogAuditEntryResponse -> AuditEntryResponse - LogAuditEntryCreatedResponse -> AuditEntryCreatedResponse - LogAuditEntryIdempotentResponse -> AuditEntryIdempotentResponse - LockInfo -> LockInfoResponse Renames (vo / error): - ExecutionAction -> CloudExecutionAction - LockStatus -> CloudLockStatus - TargetSystemAuditMarkType -> CloudTargetSystemAuditMarkType - TxStrategy -> CloudTxStrategy - FlamingockError -> CloudFlamingockError New value-object types (previously leaking from core): - CloudAuditStatus - CloudChangeType - CloudRecoveryStrategy Align request/response shapes with the new server contract (AuditEntryRequest, ExecutionPlanRequest/Response, LockResponse, StageRequest/Response) and drop the now-unused TaskRequest. Add equals()/hashCode() to ClientSubmissionRequest, StageRequest, ChangeRequest, StageResponse and ChangeResponse. These types are transitively compared by ExecutionDetailResponse.equals(), which delegates to Objects.equals() on its nested fields; without structural equality on the children, server tests asserting `responseBody shouldBe expected` failed on reference identity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.