fix: Fix raycasting "pass-through" collision inaccuracies with better modelling#3906
Merged
fix: Fix raycasting "pass-through" collision inaccuracies with better modelling#3906
Conversation
luanpotter
force-pushed
the
luan.fix-hitboxes
branch
4 times, most recently
from
c873073 to
405f7b6
Compare
spydon
approved these changes
Apr 20, 2026
Member
spydon
left a comment
spydon
left a comment
There was a problem hiding this comment.
Code looks sensible, fix the variable names to up the readability though.
luanpotter
force-pushed
the
luan.fix-hitboxes
branch
from
405f7b6 to
df3cd5a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix raycasting "pass-through" collision inaccuracies with better modelling.
I started by first principles with the formula and told the clanker to implement, so please review with some grains of salt!
The code before had some unnecessary complexity trying to check which side it was before using the intersection formula, so this is a simpler more direct approach.
There is still epsilon wrangling, in fact it is more in your face than ever, but I couldn't find a way to not have it starting from the vector2s data.
I am very open to other suggestions or alternatives here and happy to move implementation forward!
Before:
After:
Checklist
docsand added dartdoc comments with///.examplesordocs.Breaking Change?