Skip to content

Remove panelLayoutGeneration#5946

Open
mstange wants to merge 1 commit intofirefox-devtools:mainfrom
mstange:push-vlsklklmzuxm
Open

Remove panelLayoutGeneration#5946
mstange wants to merge 1 commit intofirefox-devtools:mainfrom
mstange:push-vlsklklmzuxm

Conversation

@mstange
Copy link
Copy Markdown
Contributor

@mstange mstange commented Apr 10, 2026

Main branch | Deploy preview

We originally introduced this to resolve #1205 and #736, but these days it's not needed anymore because we have ResizeObservers in the relevant places. Or at least I can't find anything that breaks. I've tried the STR from the two linked issue on the above deploy preview and it all seems to work.

@mstange mstange requested a review from canova April 10, 2026 15:34
@mstange mstange self-assigned this Apr 10, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.37%. Comparing base (e17e396) to head (38336c8).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5946      +/-   ##
==========================================
- Coverage   85.38%   85.37%   -0.02%     
==========================================
  Files         322      322              
  Lines       32101    32069      -32     
  Branches     8849     8731     -118     
==========================================
- Hits        27410    27378      -32     
  Misses       4260     4260              
  Partials      431      431              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

We originally introduced this to resolve firefox-devtools#1205 and firefox-devtools#736, but these
days it's not needed anymore because we have ResizeObservers in the
relevant places.
@mstange mstange force-pushed the push-vlsklklmzuxm branch from 9ea64a8 to 38336c8 Compare April 10, 2026 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hiding/showing timeline tracks doesn't invalidate all the sizing state in components

1 participant