Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5946 +/- ##
==========================================
- Coverage 85.38% 85.37% -0.02%
==========================================
Files 322 322
Lines 32101 32069 -32
Branches 8849 8731 -118
==========================================
- Hits 27410 27378 -32
Misses 4260 4260
Partials 431 431 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
We originally introduced this to resolve firefox-devtools#1205 and firefox-devtools#736, but these days it's not needed anymore because we have ResizeObservers in the relevant places.
9ea64a8 to
38336c8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main branch | Deploy preview
We originally introduced this to resolve #1205 and #736, but these days it's not needed anymore because we have ResizeObservers in the relevant places. Or at least I can't find anything that breaks. I've tried the STR from the two linked issue on the above deploy preview and it all seems to work.