Merged
Conversation
Checking the fill style for each sample has a lot of overhead. As an alternative, we can accumulate the samples but then just skip the drawing at the end. This improves activity graph drawing performance on https://share.firefox.dev/4aqbUN1 by 23%. Before: https://share.firefox.dev/3Oy0NtP After: https://share.firefox.dev/4aqbUN1
Checking the fill style for each sample has a lot of overhead. As an alternative, we can accumulate the samples but then just skip the drawing at the end. This improves activity graph drawing performance on https://share.firefox.dev/4aqbUN1 by 23%. Before: https://share.firefox.dev/3Oy0NtP After: https://share.firefox.dev/4aqbUN1
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com> Co-authored-by: Nazım Can Altınova <canaltinova@gmail.com>
Co-authored-by: Théo Chevalier <theo@theochevalier.org> (fr)
Co-authored-by: Valery Ledovskoy <valery@ledovskoy.com> (ru)
Co-authored-by: Michael Köhler <michael.koehler1@gmx.de> (de)
Co-authored-by: Michael Köhler <michael.koehler1@gmx.de> (de)
Co-authored-by: Francesco Lodolo [:flod] <flod+pontoon@mozilla.com> (it)
Co-authored-by: Andreas Pettersson <amvpet@gmail.com> (sv-SE)
Co-authored-by: Pin-guang Chen <petercpg@mail.moztw.org> (zh-TW)
Fixes #5838 This does: * Make jank markers (red markers) darker * Make the border colors compatible with light/dark colors * Make style markers (teal markers) darker * Make regular and highlighted samples markers (blue markers) darker * Make idle samples markers closer to the updated timeline background <img width="1277" height="680" alt="markers-2" src="https://github.com/user-attachments/assets/6c40d79d-b26a-4fd8-8d4a-d5cd30b34923" />
Fixed #5820 This removes a cached copy of photon colors inside the colors.ts, and let it directly use the photon-colors module.
Co-authored-by: Ian Neal <iann_bugzilla@blueyonder.co.uk> (en-GB)
Co-authored-by: Théo Chevalier <theo@theochevalier.org> (fr)
Co-authored-by: Mark Heijl <markh@babelzilla.org> (nl)
Co-authored-by: Fjoerfoks <fryskefirefox@gmail.com> (fy-NL)
The files are all tiny, let's embed them inline.
Co-authored-by: Jim Spentzos <jimspentzos2000@gmail.com> (el)
Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Nazım Can Altınova <canaltinova@gmail.com>
Co-authored-by: Melo46 <melo@carmu.com> (ia)
This patch changes the gecko profiler format to always include source table. The backend patch also increases the gecko profile format version. Backend bug: https://bugzilla.mozilla.org/show_bug.cgi?id=2016666 This PR has to be deployed before we can land the backend.
Backend changes for this PR: [Bug 2016666](https://bugzilla.mozilla.org/show_bug.cgi?id=2016666) This will allow us to add more fields to the source table, like `sourceMapURL` which will allow us to resolve source maps.
Co-authored-by: ravmn <ravmn@ravmn.cl> (es-CL)
Co-authored-by: Jim Spentzos <jimspentzos2000@gmail.com> (el)
Co-authored-by: Jim Spentzos <jimspentzos2000@gmail.com> (el)
de, el, en-GB, es-CL, fr, fy-NL, ia, it, nl, ru, sv-SE, zh-TW.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
[Markus Stange] Move transparent fill check to a less expensive place. (#5826)
[fatadel] refine docs for ctrl key (#5831)
[Nazım Can Altınova] Update the team members inside CONTRIBUTING.md (#5829)
[fatadel] Provide correct instructions on the home page for Firefox for Android (Fenix) (#5816)
[Markus Stange] Make markers darker (#5839)
[Markus Stange] Directly use photon-colors (#5821)
[Markus Stange] Migrate to esbuild (#5589)
[Markus Stange] Use data URLs for SVG files. (#5845)
[Markus Stange] Tweak dark mode colors some more. (#5846)
[Nazım Can Altınova] Make the source table non-optional in the gecko profile format (#5842)
[fatadel] fix foreground color of the button on error page (#5849)
[Nazım Can Altınova] 🔃 Sync: l10n -> main (February 24, 2026) (#5855)
And special thanks to our localizers:
de: Michael Köhler
el: Jim Spentzos
en-GB: Ian Neal
es-CL: ravmn
fr: Théo Chevalier
fy-NL: Fjoerfoks
ia: Melo46
it: Francesco Lodolo [:flod]
nl: Mark Heijl
ru: Valery Ledovskoy
sv-SE: Andreas Pettersson
zh-TW: Pin-guang Chen