Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates dependency versions across several modules, including Firebase BoM, AndroidX components, and Kotlin. The review feedback suggests utilizing the Version Catalog for hardcoded dependencies to improve maintainability and identifies a version mismatch for the Firebase BoM between the module files and the central catalog.
|
|
||
| // Import the Firebase BoM (see: https://firebase.google.com/docs/android/learn-more#bom) | ||
| implementation(platform("com.google.firebase:firebase-bom:34.7.0")) | ||
| implementation(platform("com.google.firebase:firebase-bom:34.12.0")) |
There was a problem hiding this comment.
The Firebase BoM version 34.12.0 used here is inconsistent with the version 34.11.0 defined in gradle/libs.versions.toml. Please update the Version Catalog and use the libs.firebase.bom reference to maintain consistency across the project.
implementation(platform(libs.firebase.bom))
There was a problem hiding this comment.
Should be fixed by GoogleCloudPlatform/repository-gardener#201
| implementation("androidx.navigation:navigation-fragment-ktx:2.9.8") | ||
| implementation("androidx.navigation:navigation-ui-ktx:2.9.8") |
There was a problem hiding this comment.
These Navigation dependencies are hardcoded to version 2.9.8, which matches the composeNavigation version updated in the Version Catalog. It is recommended to define these artifacts in libs.versions.toml and use the catalog references here.
| implementation("androidx.activity:activity-ktx:1.13.0") | ||
| implementation("androidx.appcompat:appcompat:1.7.1") | ||
| implementation("androidx.core:core-ktx:1.17.0") | ||
| implementation("androidx.core:core-ktx:1.18.0") |
There was a problem hiding this comment.
This dependency should use the Version Catalog reference instead of a hardcoded string, as core-ktx is already defined in libs.versions.toml.
implementation(libs.androidx.core.ktx)| implementation("androidx.annotation:annotation:1.10.0") | ||
| implementation("androidx.vectordrawable:vectordrawable-animated:1.2.0") | ||
| implementation("androidx.core:core-ktx:1.17.0") | ||
| implementation("androidx.core:core-ktx:1.18.0") |
There was a problem hiding this comment.
This dependency should use the Version Catalog reference instead of a hardcoded string, as core-ktx is already defined in libs.versions.toml.
implementation(libs.androidx.core.ktx)| implementation(project(":internal:lintchecks")) | ||
| implementation(project(":internal:chooserx")) | ||
| implementation("androidx.annotation:annotation:1.9.1") | ||
| implementation("androidx.annotation:annotation:1.10.0") |
There was a problem hiding this comment.
The androidx.annotation version 1.10.0 is duplicated in both implementation and androidTestImplementation (line 80). It is recommended to move this to the Version Catalog to simplify future updates.
| compileOnly("com.android.tools.lint:lint-api:32.2.0") | ||
| testImplementation("com.android.tools.lint:lint:32.2.0") | ||
| testImplementation("com.android.tools.lint:lint-tests:32.2.0") |
There was a problem hiding this comment.
The Lint version 32.2.0 is hardcoded and duplicated across multiple dependencies. It is recommended to define this version in the Version Catalog and reference it here.
2 participants
Brought to you by your friendly Repository Gardener.