-
Notifications
You must be signed in to change notification settings - Fork 415
chore: bump eslint to 10.3.0 and migrate to flat config #3150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lahirumaramba
wants to merge
6
commits into
v14
Choose a base branch
from
lm-bump-eslint
base: v14
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
d4ff792
chore: bump eslint to 10.3.0 and migrate to flat config
lahirumaramba 492cf4d
add missing copyright header
lahirumaramba 4e2bc87
remove extra whitespaces
lahirumaramba 6368854
chore: restrict mocha globals to test files in flat config
lahirumaramba 8a5de0e
unpin eslint
lahirumaramba 36ac53c
chore: adopt native defineConfig and streamline test globs in flat co…
lahirumaramba File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,153 @@ | ||
| /*! | ||
| * Copyright 2026 Google LLC | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
|
lahirumaramba marked this conversation as resolved.
|
||
| * limitations under the License. | ||
| */ | ||
|
|
||
| import { defineConfig } from 'eslint/config'; | ||
| import eslint from '@eslint/js'; | ||
| import tseslint from 'typescript-eslint'; | ||
| import globals from 'globals'; | ||
|
|
||
| export default defineConfig([ | ||
| eslint.configs.recommended, | ||
| ...tseslint.configs.recommended, | ||
| { | ||
| files: ['src/**/*.ts', 'test/**/*.ts'], | ||
| languageOptions: { | ||
| globals: { | ||
| ...globals.node, | ||
| }, | ||
| }, | ||
| rules: { | ||
| // Following checks are temporarily disabled. We shall incrementally enable them in the | ||
| // future, fixing any violations as we go. | ||
| '@typescript-eslint/no-non-null-assertion': 0, | ||
|
|
||
| // Disabled checks | ||
| '@typescript-eslint/no-explicit-any': 0, | ||
| '@typescript-eslint/no-use-before-define': 0, | ||
| '@typescript-eslint/no-var-requires': 0, | ||
| '@typescript-eslint/no-require-imports': 0, | ||
| '@typescript-eslint/no-unused-expressions': 0, | ||
|
|
||
| // Required checks | ||
| 'indent': ['error', 2], | ||
| 'keyword-spacing': ['error'], | ||
| 'max-len': [ | ||
| 'error', | ||
| { | ||
| 'code': 120, | ||
| 'ignoreUrls': true | ||
| } | ||
| ], | ||
| 'object-curly-spacing': [2, 'always'], | ||
| '@typescript-eslint/explicit-function-return-type': [ | ||
| 'error', | ||
| { | ||
| 'allowExpressions': true, | ||
| 'allowTypedFunctionExpressions': true, | ||
| 'allowHigherOrderFunctions': true | ||
| } | ||
| ], | ||
| 'no-unused-vars': 'off', // Must be disabled to enable the next rule | ||
| '@typescript-eslint/no-unused-vars': [ | ||
| 'error', | ||
| { | ||
| 'varsIgnorePattern': '^_', | ||
| 'argsIgnorePattern': '^_', | ||
| 'caughtErrors': 'none' | ||
| } | ||
| ], | ||
| 'quotes': ['error', 'single', {'avoidEscape': true}], | ||
| '@typescript-eslint/naming-convention': [ | ||
| 'error', | ||
| { | ||
| "selector": "variable", | ||
| "format": ["camelCase", "UPPER_CASE"] | ||
| }, | ||
| { | ||
| "selector": "parameter", | ||
| "format": ["camelCase"], | ||
| "leadingUnderscore": "allow" | ||
| }, | ||
|
|
||
| { | ||
| "selector": "memberLike", | ||
| "format": ["camelCase"] | ||
| }, | ||
|
|
||
| { | ||
| "selector": "typeLike", | ||
| "format": ["PascalCase"] | ||
| }, | ||
|
|
||
| // Ignore properties that require quotes (HTTP headers, names that include spaces or dashes etc.). | ||
| { | ||
| "selector": [ | ||
| "classProperty", | ||
| "objectLiteralProperty", | ||
| "typeProperty", | ||
| "classMethod", | ||
| "objectLiteralMethod", | ||
| "typeMethod", | ||
| "accessor", | ||
| "enumMember" | ||
| ], | ||
| "format": null, | ||
| "modifiers": ["requiresQuotes"] | ||
| }, | ||
|
|
||
| // Ignore destructured property names. | ||
| { | ||
| "selector": "variable", | ||
| "modifiers": ["destructured"], | ||
| "format": null | ||
| }, | ||
|
|
||
| // Following types are temporarily disabled. We shall incrementally enable them in the | ||
| // future, fixing any violations as we go. | ||
| { | ||
| "selector": [ | ||
| "classProperty", | ||
| "objectLiteralProperty", | ||
| "typeProperty", | ||
| "enumMember" | ||
| ], | ||
| "format": null | ||
| } | ||
| ], | ||
| } | ||
| }, | ||
| { | ||
| files: ['test/**/*.ts'], | ||
| languageOptions: { | ||
| globals: { | ||
| ...globals.mocha, | ||
| }, | ||
| }, | ||
| }, | ||
| { | ||
| ignores: [ | ||
| 'lib/', | ||
| 'node_modules/', | ||
| 'temp/', | ||
| 'docgen/', | ||
| 'dist/', | ||
| 'coverage/', | ||
| '**/*.d.ts', | ||
| '**/*.js', | ||
| 'firebase-admin-*.tgz' | ||
| ] | ||
| } | ||
| ]); | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.