Fix: solves the duplicate variable name error in styles-to-variables plugin#150
Open
JonatasT wants to merge 1 commit intofigma:mainfrom
Open
Fix: solves the duplicate variable name error in styles-to-variables plugin#150JonatasT wants to merge 1 commit intofigma:mainfrom
JonatasT wants to merge 1 commit intofigma:mainfrom
Conversation
akbarbmirza
requested changes
Nov 28, 2023
Collaborator
akbarbmirza
left a comment
akbarbmirza
left a comment
There was a problem hiding this comment.
this change looks good to me but I would suggest adding some comments to explain this behavior and adding this limitation to a README for that sample so that people are explicitly aware that the sample is treating duplicate token names like this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! I believe the root cause of the issue #142 stems from having multiple styles associated with the same "token" name. To avoid a repeat of this incident, we can rectify the tokenData by appending a numerical suffix to the token style names. That being said, I have devised an alternate solution that may be of interest to you. Thank you for your time, and your attention.