Rename local max output env var to SMITH prefix#41
Merged
faustodavid merged 2 commits intoJun 1, 2026
Conversation
Prefer SMITH_LOCAL_MAX_OUTPUT_CHARS while keeping THANOS_LOCAL_MAX_OUTPUT_CHARS as a backwards-compatible fallback, and update docs/tests to reflect the new canonical variable. Co-authored-by: Cursor <cursoragent@cursor.com>
Cover the invalid new env-var scenario to ensure runtime config falls back to the legacy THANOS variable during the compatibility window. Co-authored-by: Cursor <cursoragent@cursor.com>
faustodavid
reviewed
May 20, 2026
Owner
|
@codex review |
|
Codex Review: Didn't find any major issues. 👍 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
THANOS_LOCAL_MAX_OUTPUT_CHARStoSMITH_LOCAL_MAX_OUTPUT_CHARS.THANOS_LOCAL_MAX_OUTPUT_CHARSwhen the new variable is unset..env.exampleto document the new canonical variable.Closes #27.
Test plan
pytest tests/unit/test_config.pypytest tests/unit