Open
Conversation
Contributor
📝 Docs previewLast commit 9103510 at: https://c409eb10.sqlmodel.pages.dev |
…rs are before it (invalid-legacy-positional-parameter)
svlandeg
commented
Mar 10, 2026
svlandeg
commented
Mar 10, 2026
github-actions
bot
added
the
conflicts
This comment was marked as resolved.
This comment was marked as resolved.
# Conflicts: # pyproject.toml # uv.lock
github-actions
bot
removed
the
conflicts
This comment was marked as resolved.
This comment was marked as resolved.
github-actions
bot
added
the
conflicts
# Conflicts: # pyproject.toml # uv.lock
github-actions
bot
removed
the
conflicts
YuriiMotov
reviewed
Mar 16, 2026
Member
YuriiMotov
left a comment
YuriiMotov
left a comment
There was a problem hiding this comment.
Added a few suggestions in the comments. Please, take a look)
| its `WHERE` clause, joined to the existing clause via `AND`, if any. | ||
| """ | ||
| return super().where(*whereclause) # type: ignore[arg-type] | ||
| return super().where(*whereclause) |
Member
There was a problem hiding this comment.
It's ty's mistake that it doesn't notice type mismatch here. But I checked - passing bool argument works in runtime
Member
Author
|
@YuriiMotov, thanks for the review! I addressed everything, looks better IMO 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mypywithtyin precommit,lint.sh& pyproject.toml.tyhappyI originally set out to have
mypyandtyrun together in precommit, but forsqlmodelI would argue that perhaps we want to removemypyalltogether already now, as it allows us to remove a lot oftype: ignorestatements thattythinks are unnecessary anyway.