Introduce lazy loading as an optional config#3228
Open
stefannibrasil wants to merge 4 commits intolazy-loading-betafrom
Open
Introduce lazy loading as an optional config#3228stefannibrasil wants to merge 4 commits intolazy-loading-betafrom
stefannibrasil wants to merge 4 commits intolazy-loading-betafrom
Conversation
stefannibrasil
force-pushed
the
sb/introduce-lazy-load
branch
3 times, most recently
from
103500c to
0c9dc19
Compare
To keep this change backwards compatible, we introduce lazy loading as a config option. We need to load main classes first for nested generators such as 'music' and when lazy loading is not enabled. 'internet/http'. This will avoid the need for renaming these generators. Co-authored-by: Thiago Araujo <thd.araujo@gmail.com>
stefannibrasil
force-pushed
the
sb/introduce-lazy-load
branch
from
d4e9ddb to
4c06713
Compare
stefannibrasil
changed the title
stefannibrasil
force-pushed
the
sb/introduce-lazy-load
branch
from
4c06713 to
1ca07ae
Compare
stefannibrasil
commented
Mar 13, 2026
|
|
||
| - name: Run tests | ||
| run: bundle exec rake test | ||
| test-with-lazy-loading: |
Contributor
Author
There was a problem hiding this comment.
I don't think we need to run the tests for every ruby version. Just one is enough?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation / Background
Closes #3161
This Pull Request has been created because after running experiments documented in https://github.com/faker-ruby/faker/tree/main/experiments, we decided to go with lazy loading, and we want to release a beta version for users to report any issues using lazy loading.
Lazy loading is disabled by default and can be enabled by setting a config:
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]