Skip to content

Fix: ReactDOM.preloadModule crashes with repeated custom as value#36454

Open
jshaofa-ui wants to merge 1 commit into
facebook:mainfrom
jshaofa-ui:fix-preloadmodule-custom-as-crash
Open

Fix: ReactDOM.preloadModule crashes with repeated custom as value#36454
jshaofa-ui wants to merge 1 commit into
facebook:mainfrom
jshaofa-ui:fix-preloadmodule-custom-as-crash

Conversation

@jshaofa-ui
Copy link
Copy Markdown

Summary

Fixes a crash in ReactDOM.preloadModule() when called multiple times with the same custom as value (e.g., as: 'serviceworker').

Root Cause

In ReactFizzConfigDOM.js line 6555, the code checks resumableState.moduleUnknownResources.hasOwnProperty(as) but then reads from resumableState.unknownResources[as] — which is undefined for custom as types since they're stored in moduleUnknownResources, not unknownResources.

Fix

One-word change: unknownResourcesmoduleUnknownResources on line 6555.

Before:

resources = resumableState.unknownResources[as];  // undefined for custom as

After:

resources = resumableState.moduleUnknownResources[as];  // correct bucket

Reproduction

function App() {
  ReactDOM.preloadModule('worker-a', {as: 'serviceworker'});
  ReactDOM.preloadModule('worker-b', {as: 'serviceworker'});
  return <div>hello</div>;
}

The second call crashes with: TypeError: Cannot read properties of undefined (reading 'hasOwnProperty')

Fixes #36440

The repeated custom-`as` path checks `moduleUnknownResources` but then
reads the bucket from `unknownResources`, so the bucket can be undefined.

Fixed by reading from `moduleUnknownResources` instead of `unknownResources`
on line 6555 of ReactFizzConfigDOM.js.

Fixes facebook#36440
@meta-cla
Copy link
Copy Markdown

meta-cla Bot commented May 12, 2026

Hi @jshaofa-ui!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: ReactDOM.preloadModule crashes with repeated custom as value

1 participant