fix: remove unsafe eval() in extensions.js#56667
Open
orbisai0security wants to merge 1 commit intofacebook:mainfrom
Open
fix: remove unsafe eval() in extensions.js#56667orbisai0security wants to merge 1 commit intofacebook:mainfrom
orbisai0security wants to merge 1 commit intofacebook:mainfrom
Conversation
Automated security fix generated by Orbis Security AI
|
Warning Missing Test Plan Please add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix critical severity security issue in
packages/debugger-frontend/dist/third-party/front_end/models/extensions/extensions.js.Vulnerability
V-002packages/debugger-frontend/dist/third-party/front_end/models/extensions/extensions.js:1Description: The ExtensionServer.evaluate() method executes arbitrary JavaScript expressions in the context of the inspected web page via the Chrome DevTools Protocol. The only permission check is extensionAllowedOnURL(), which validates the target URL against the extension's declared hostsPolicy. An extension registered with '<all_urls>' in runtimeAllowedHosts satisfies this check for any URL, enabling unrestricted JavaScript execution in any inspected page. No user confirmation is required, and no sandboxing limits the scope of the executed code.
Changes
packages/debugger-frontend/dist/third-party/front_end/models/extensions/extensions.jsVerification
Automated security fix by OrbisAI Security