[0.85] Fix silent tar extraction failure on EdenFS in replace-rncore-version#56644
Open
motiz88 wants to merge 1 commit intofacebook:0.85-stablefrom
Open
[0.85] Fix silent tar extraction failure on EdenFS in replace-rncore-version#56644motiz88 wants to merge 1 commit intofacebook:0.85-stablefrom
motiz88 wants to merge 1 commit intofacebook:0.85-stablefrom
Conversation
…facebook#55797) Summary: On EdenFS, `tar -xf` extraction directly into an EdenFS-mounted directory silently produces incomplete results — only the first slice of the tarball (ios-arm64) gets extracted, while the remaining entries (catalyst, simulator, top-level Headers) have their directories created but files are missing. The `replace-rncore-version.js` script didn't check tar's exit code, so it would write the config file and subsequent builds would skip re-extraction. This fix extracts the tarball to a temporary directory on a regular filesystem first, verifies the extraction succeeded (exit code + expected file check), then moves the results into the final location. This is adapted from D94625297 (which targeted 0.83) to work with the current main branch, preserving the v0.84 behavior of only deleting subdirectories in `React-Core-prebuilt` (keeping files like `React-VFS.yaml`). ## Changelog: [IOS] [FIXED] - Fix silent tar extraction failure on EdenFS in replace-rncore-version.js by extracting to a temp directory first Pull Request resolved: facebook#55797 Test Plan: Validated by the original patch author on EdenFS in D94625297. The logic is equivalent, adapted for the v0.84 code which preserves files in the target directory. Reviewed By: cortinico Differential Revision: D94653392 Pulled By: cipolleschi fbshipit-source-id: f2f1956b434586f0a83e1ec648a03dbac25333f5
meta-cla
Bot
added
the
CLA Signed
|
Warning JavaScript API change detected This PR commits an update to
This change was flagged as: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cherry-pick of 9bc7d38be07 (#55797) from
main.Fixes silent tar extraction failures on EdenFS-mounted directories in
replace-rncore-version.jsby extracting to a temp directory first, then moving the results into the final location.Previously picked to 0.83-stable as becef72f121 (#55795, different patch adapted for 0.83).
Changelog:
[IOS] [FIXED] - Fix silent tar extraction failure on EdenFS in replace-rncore-version.js
Test Plan
cc @cipolleschi