[0.85] Add Fast Refresh performance marker and unstable_fastRefreshComplete CDP event#56639
Open
motiz88 wants to merge 3 commits intofacebook:0.85-stablefrom
Open
[0.85] Add Fast Refresh performance marker and unstable_fastRefreshComplete CDP event#56639motiz88 wants to merge 3 commits intofacebook:0.85-stablefrom
motiz88 wants to merge 3 commits intofacebook:0.85-stablefrom
Conversation
Summary: Pull Request resolved: facebook#56176 NOTE: Resubmission of D84624705. Adds a prominent vertical "Fast Refresh ⚛︎" marker entry in the performance timeline when a Fast Refresh update is complete. Changelog: [Internal] Reviewed By: GijsWeterings Differential Revision: D97486551 fbshipit-source-id: 4c70b674370bab06f02e8d356bbd2979c9686a44
Summary: Pull Request resolved: facebook#56273 Adds a new, experimental `ReactNativeApplication.unstable_fastRefreshComplete` CDP event, emitted to subscribed active CDP sessions when a Fast Refresh update completes. **Notes** - As with D97486551, we reuse the `changeId` block in `HMRClient.js`, ensuring duplicate updates for the same change are not reported. Changelog: [Internal] Reviewed By: GijsWeterings, hoxyq Differential Revision: D98493216 fbshipit-source-id: b0b81a210fb84873e9358aa5484038062f110103
meta-cla
Bot
added
the
CLA Signed
|
Warning JavaScript API change detected This PR commits an update to
This change was flagged as: |
Metro 0.84.3 adds `changeId` to HMR `update-done` messages, which is required by the `unstable_fastRefreshComplete` CDP event and the Fast Refresh performance marker to deduplicate events across multiple updates for the same file change.
motiz88
force-pushed
the
pick-fast-refresh-complete-0.85
branch
from
01c3f73 to
dce75e2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cherry-pick of 2 commits from
mainplus a Metro dependency bump, adding:performance.mark('Fast Refresh - Update done')entry in the performance timeline when a Fast Refresh update completes, deduplicated by Metro'schangeId.unstable_fastRefreshCompleteCDP event (Add unstable_fastRefreshComplete CDP event (#56273) #56273) — emits a new experimentalReactNativeApplication.unstable_fastRefreshCompleteCDP event to subscribed sessions, reusing the samechangeId-based deduplication.^0.84.3— Metro 0.84.3 addschangeIdto HMRupdate-donemessages, which is required by both of the above for event deduplication.Previously backported to 0.83-stable in #56399 (which included a Metro bump from 0.83.3 to 0.83.6 for the same reason).
Changelog:
[Internal]
Test Plan
cc @huntie