Add yoga submodule to react-native/third-party#55664
Open
NickGerleman wants to merge 1 commit intomainfrom
Open
Add yoga submodule to react-native/third-party#55664NickGerleman wants to merge 1 commit intomainfrom
NickGerleman wants to merge 1 commit intomainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
|
Warning Missing Test Plan Please add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested. |
|
@NickGerleman has imported this pull request. If you are a Meta employee, you can view this in D93955364. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Playing with what it would look like to do ShipIt submodule syncing instead of dirsyncs for syncing Yoga from React Native. First step of that is creating a submodule as normal. I thought
third-party, in the package, would be a good way to get something clear into the npm package to distribute, in a single place, but it also I think conflicts with a build output that prebuilds use. Not sure where each should go.Meta employees can learn more about submodule syncing here.
Changelog: [Internal]