Skip to content

Use ConfigurationCompat for locale access in I18nManagerModule #55663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alanleedev wants to merge 1 commit into from
Closed

Use ConfigurationCompat for locale access in I18nManagerModule #55663

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ...ve/ReactAndroid/src/main/java/com/facebook/react/modules/i18nmanager/I18nManagerModule.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,17 +7,20 @@

package com.facebook.react.modules.i18nmanager

import androidx.core.os.ConfigurationCompat
import com.facebook.fbreact.specs.NativeI18nManagerSpec
import com.facebook.react.bridge.ReactApplicationContext
import com.facebook.react.module.annotations.ReactModule
import java.util.Locale

/** [com.facebook.react.bridge.NativeModule] that allows JS to set allowRTL and get isRTL status. */
@ReactModule(name = NativeI18nManagerSpec.NAME)
internal class I18nManagerModule(context: ReactApplicationContext?) :
NativeI18nManagerSpec(context) {
override fun getTypedExportedConstants(): Map<String, Any> {
val context = reactApplicationContext
val locale = context.resources.configuration.locales[0]
val locale =
ConfigurationCompat.getLocales(context.resources.configuration)[0] ?: Locale.getDefault()

return mapOf(
"isRTL" to I18nUtil.instance.isRTL(context),
Expand Down