Fix infinite recursion in ReactPropAnnotationSetterSpecTest#55662
Open
edelron wants to merge 1 commit intofacebook:mainfrom
Open
Fix infinite recursion in ReactPropAnnotationSetterSpecTest#55662edelron wants to merge 1 commit intofacebook:mainfrom
edelron wants to merge 1 commit intofacebook:mainfrom
Conversation
Summary: Fix infinite recursion bugs in `ReactPropAnnotationSetterSpecTest.kt`: - `createShadowNodeInstance()` (line 25): Method calls itself recursively instead of creating a shadow node instance. Fixed to return `ReactShadowNodeImpl()`, which is the concrete implementation of `ReactShadowNode`. - `createViewInstance(reactContext)` (line 30): Method calls itself recursively instead of creating a view instance. Fixed to return `View(reactContext)`, which creates a basic Android View. Both methods are in an abstract inner `BaseViewManager` test class used to satisfy the `ViewManager` abstract contract. The test class is only used to verify `ReactProp` annotation validation, so these methods just need to return valid instances. Detected by InfiniteRecursion lint detector (D93897169). Differential Revision: D93927939
meta-cla
bot
added
the
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fix infinite recursion bugs in
ReactPropAnnotationSetterSpecTest.kt:createShadowNodeInstance()(line 25): Method calls itself recursively instead of creating a shadow node instance. Fixed to returnReactShadowNodeImpl(), which is the concrete implementation ofReactShadowNode.createViewInstance(reactContext)(line 30): Method calls itself recursively instead of creating a view instance. Fixed to returnView(reactContext), which creates a basic Android View.Both methods are in an abstract inner
BaseViewManagertest class used to satisfy theViewManagerabstract contract. The test class is only used to verifyReactPropannotation validation, so these methods just need to return valid instances.Detected by InfiniteRecursion lint detector (D93897169).
Differential Revision: D93927939