Add NativeViewHierarchyOptimizer parameter to ReactShadowNode methods#55661
Closed
mdvacca wants to merge 1 commit intofacebook:mainfrom
Closed
Add NativeViewHierarchyOptimizer parameter to ReactShadowNode methods#55661mdvacca wants to merge 1 commit intofacebook:mainfrom
mdvacca wants to merge 1 commit intofacebook:mainfrom
Conversation
c0df300 to
1ba9b3e
Compare
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Feb 20, 2026
…facebook#55661) Summary: Add a `NativeViewHierarchyOptimizer` parameter to `onBeforeLayout()` and `dispatchUpdates()` methods in `ReactShadowNode` and `ReactShadowNodeImpl`. This introduces a deprecated stub class `NativeViewHierarchyOptimizer.kt` annotated with `LegacyArchitecture` to support downstream callers that still reference this type, while signaling that it is part of the legacy architecture and will be removed in the future. Callers in `UIImplementation` pass `null` for now since the optimizer is not actively used in this code path. Changelog: [Android][Deprecated] - Deprecate NativeViewHierarchyOptimizer as part of Legacy Architecture cleanup Reviewed By: NickGerleman Differential Revision: D93935604
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Feb 21, 2026
…facebook#55661) Summary: Pull Request resolved: facebook#55661 Add a `NativeViewHierarchyOptimizer` parameter to `onBeforeLayout()` and `dispatchUpdates()` methods in `ReactShadowNode` and `ReactShadowNodeImpl`. This introduces a deprecated stub class `NativeViewHierarchyOptimizer.kt` annotated with `LegacyArchitecture` to support downstream callers that still reference this type, while signaling that it is part of the legacy architecture and will be removed in the future. Callers in `UIImplementation` pass `null` for now since the optimizer is not actively used in this code path. Changelog: [Android][Deprecated] - Deprecate NativeViewHierarchyOptimizer as part of Legacy Architecture cleanup Reviewed By: NickGerleman Differential Revision: D93935604
1ba9b3e to
664d62b
Compare
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Feb 21, 2026
…facebook#55661) Summary: Add a `NativeViewHierarchyOptimizer` parameter to `onBeforeLayout()` and `dispatchUpdates()` methods in `ReactShadowNode` and `ReactShadowNodeImpl`. This introduces a deprecated stub class `NativeViewHierarchyOptimizer.kt` annotated with `LegacyArchitecture` to support downstream callers that still reference this type, while signaling that it is part of the legacy architecture and will be removed in the future. Callers in `UIImplementation` pass `null` for now since the optimizer is not actively used in this code path. Changelog: [Android][Deprecated] - Deprecate NativeViewHierarchyOptimizer as part of Legacy Architecture cleanup Reviewed By: NickGerleman Differential Revision: D93935604
664d62b to
7e65e60
Compare
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Feb 21, 2026
…facebook#55661) Summary: Pull Request resolved: facebook#55661 Add a `NativeViewHierarchyOptimizer` parameter to `onBeforeLayout()` and `dispatchUpdates()` methods in `ReactShadowNode` and `ReactShadowNodeImpl`. This introduces a deprecated stub class `NativeViewHierarchyOptimizer.kt` annotated with `LegacyArchitecture` to support downstream callers that still reference this type, while signaling that it is part of the legacy architecture and will be removed in the future. Callers in `UIImplementation` pass `null` for now since the optimizer is not actively used in this code path. Changelog: [Android][Deprecated] - Deprecate NativeViewHierarchyOptimizer as part of Legacy Architecture cleanup Reviewed By: NickGerleman Differential Revision: D93935604
7e65e60 to
0b57c7b
Compare
…facebook#55661) Summary: Add a `NativeViewHierarchyOptimizer` parameter to `onBeforeLayout()` and `dispatchUpdates()` methods in `ReactShadowNode` and `ReactShadowNodeImpl`. This introduces a deprecated stub class `NativeViewHierarchyOptimizer.kt` annotated with `LegacyArchitecture` to support downstream callers that still reference this type, while signaling that it is part of the legacy architecture and will be removed in the future. Callers in `UIImplementation` pass `null` for now since the optimizer is not actively used in this code path. Changelog: [Android][Deprecated] - Deprecate NativeViewHierarchyOptimizer as part of Legacy Architecture cleanup Reviewed By: NickGerleman Differential Revision: D93935604
0b57c7b to
f67107a
Compare
Collaborator
|
This pull request was successfully merged by @mdvacca in 352d73b When will my fix make it into a release? | How to file a pick request? |
|
This pull request has been merged in 352d73b. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Add a
NativeViewHierarchyOptimizerparameter toonBeforeLayout()anddispatchUpdates()methods inReactShadowNodeandReactShadowNodeImpl. This introduces a deprecated stub classNativeViewHierarchyOptimizer.ktannotated withLegacyArchitectureto support downstream callers that still reference this type, while signaling that it is part of the legacy architecture and will be removed in the future.Callers in
UIImplementationpassnullfor now since the optimizer is not actively used in this code path.Changelog: [Android][Deprecated] - Deprecate NativeViewHierarchyOptimizer as part of Legacy Architecture cleanup
Differential Revision: D93935604