Skip to content

Comments

Add NativeViewHierarchyOptimizer parameter to ReactShadowNode methods#55661

Closed
mdvacca wants to merge 1 commit intofacebook:mainfrom
mdvacca:export-D93935604
Closed

Add NativeViewHierarchyOptimizer parameter to ReactShadowNode methods#55661
mdvacca wants to merge 1 commit intofacebook:mainfrom
mdvacca:export-D93935604

Conversation

@mdvacca
Copy link
Contributor

@mdvacca mdvacca commented Feb 20, 2026

Summary:
Add a NativeViewHierarchyOptimizer parameter to onBeforeLayout() and dispatchUpdates() methods in ReactShadowNode and ReactShadowNodeImpl. This introduces a deprecated stub class NativeViewHierarchyOptimizer.kt annotated with LegacyArchitecture to support downstream callers that still reference this type, while signaling that it is part of the legacy architecture and will be removed in the future.

Callers in UIImplementation pass null for now since the optimizer is not actively used in this code path.

Changelog: [Android][Deprecated] - Deprecate NativeViewHierarchyOptimizer as part of Legacy Architecture cleanup

Differential Revision: D93935604

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 20, 2026
@meta-codesync
Copy link

meta-codesync bot commented Feb 20, 2026

@mdvacca has exported this pull request. If you are a Meta employee, you can view the originating Diff in D93935604.

mdvacca added a commit to mdvacca/react-native that referenced this pull request Feb 20, 2026
…facebook#55661)

Summary:

Add a `NativeViewHierarchyOptimizer` parameter to `onBeforeLayout()` and `dispatchUpdates()` methods in `ReactShadowNode` and `ReactShadowNodeImpl`. This introduces a deprecated stub class `NativeViewHierarchyOptimizer.kt` annotated with `LegacyArchitecture` to support downstream callers that still reference this type, while signaling that it is part of the legacy architecture and will be removed in the future.

Callers in `UIImplementation` pass `null` for now since the optimizer is not actively used in this code path.

Changelog: [Android][Deprecated] - Deprecate NativeViewHierarchyOptimizer as part of Legacy Architecture cleanup

Reviewed By: NickGerleman

Differential Revision: D93935604
mdvacca added a commit to mdvacca/react-native that referenced this pull request Feb 21, 2026
…facebook#55661)

Summary:
Pull Request resolved: facebook#55661

Add a `NativeViewHierarchyOptimizer` parameter to `onBeforeLayout()` and `dispatchUpdates()` methods in `ReactShadowNode` and `ReactShadowNodeImpl`. This introduces a deprecated stub class `NativeViewHierarchyOptimizer.kt` annotated with `LegacyArchitecture` to support downstream callers that still reference this type, while signaling that it is part of the legacy architecture and will be removed in the future.

Callers in `UIImplementation` pass `null` for now since the optimizer is not actively used in this code path.

Changelog: [Android][Deprecated] - Deprecate NativeViewHierarchyOptimizer as part of Legacy Architecture cleanup

Reviewed By: NickGerleman

Differential Revision: D93935604
mdvacca added a commit to mdvacca/react-native that referenced this pull request Feb 21, 2026
…facebook#55661)

Summary:

Add a `NativeViewHierarchyOptimizer` parameter to `onBeforeLayout()` and `dispatchUpdates()` methods in `ReactShadowNode` and `ReactShadowNodeImpl`. This introduces a deprecated stub class `NativeViewHierarchyOptimizer.kt` annotated with `LegacyArchitecture` to support downstream callers that still reference this type, while signaling that it is part of the legacy architecture and will be removed in the future.

Callers in `UIImplementation` pass `null` for now since the optimizer is not actively used in this code path.

Changelog: [Android][Deprecated] - Deprecate NativeViewHierarchyOptimizer as part of Legacy Architecture cleanup

Reviewed By: NickGerleman

Differential Revision: D93935604
mdvacca added a commit to mdvacca/react-native that referenced this pull request Feb 21, 2026
…facebook#55661)

Summary:
Pull Request resolved: facebook#55661

Add a `NativeViewHierarchyOptimizer` parameter to `onBeforeLayout()` and `dispatchUpdates()` methods in `ReactShadowNode` and `ReactShadowNodeImpl`. This introduces a deprecated stub class `NativeViewHierarchyOptimizer.kt` annotated with `LegacyArchitecture` to support downstream callers that still reference this type, while signaling that it is part of the legacy architecture and will be removed in the future.

Callers in `UIImplementation` pass `null` for now since the optimizer is not actively used in this code path.

Changelog: [Android][Deprecated] - Deprecate NativeViewHierarchyOptimizer as part of Legacy Architecture cleanup

Reviewed By: NickGerleman

Differential Revision: D93935604
…facebook#55661)

Summary:

Add a `NativeViewHierarchyOptimizer` parameter to `onBeforeLayout()` and `dispatchUpdates()` methods in `ReactShadowNode` and `ReactShadowNodeImpl`. This introduces a deprecated stub class `NativeViewHierarchyOptimizer.kt` annotated with `LegacyArchitecture` to support downstream callers that still reference this type, while signaling that it is part of the legacy architecture and will be removed in the future.

Callers in `UIImplementation` pass `null` for now since the optimizer is not actively used in this code path.

Changelog: [Android][Deprecated] - Deprecate NativeViewHierarchyOptimizer as part of Legacy Architecture cleanup

Reviewed By: NickGerleman

Differential Revision: D93935604
@meta-codesync meta-codesync bot closed this in 352d73b Feb 21, 2026
@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Feb 21, 2026
@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @mdvacca in 352d73b

When will my fix make it into a release? | How to file a pick request?

@meta-codesync
Copy link

meta-codesync bot commented Feb 21, 2026

This pull request has been merged in 352d73b.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. meta-exported p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants