Support textBreakStrategy and justificationMode for Selectable Facsimile TextView#55660
Open
NickGerleman wants to merge 3 commits intofacebook:mainfrom
Open
Support textBreakStrategy and justificationMode for Selectable Facsimile TextView#55660NickGerleman wants to merge 3 commits intofacebook:mainfrom
NickGerleman wants to merge 3 commits intofacebook:mainfrom
Conversation
…k#55634) Summary: Extract ParagraphComponentDescriptor logic into a template base class BaseParagraphComponentDescriptor<ShadowNodeT> so that other paragraph-like component descriptors can reuse the same TextLayoutManager wiring. Remove `final` from ParagraphShadowNode to allow subclassing. Move TextLayoutManagerKey from extern linkage in .cpp to constexpr in the new header. This is a pure refactor with no behavioral change. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D93829402
Summary: Add the native components needed to route selectable text through ReactTextView instead of PreparedLayoutTextView when enablePreparedTextLayout is on. C++ side: Add SelectableParagraphShadowNode (inherits ParagraphShadowNode) and SelectableParagraphComponentDescriptor (inherits BaseParagraphComponentDescriptor). Register in CoreComponentsRegistry and componentNameByReactViewName. Android side: Make ReactTextViewManager open so it can be subclassed. Add getReactTextUpdateFromPreparedLayout to handle ReferenceStateWrapper holding PreparedLayout. Create SelectableTextViewManager (extends ReactTextViewManager, registered as RCTSelectableText). Add FabricNameComponentMapping entry for SelectableParagraph -> RCTSelectableText. No JS code references RCTSelectableText yet, so the new components are inert. Changelog: [Internal] Differential Revision: D93829400
…ile TextView Summary: `getReactTextUpdateFromPreparedLayout()` hardcoded `textBreakStrategy` to `BREAK_STRATEGY_HIGH_QUALITY` and `justificationMode` to `0`, causing user-specified values like `textBreakStrategy: "simple"` or `textAlign: "justify"` to be ignored when the PreparedLayout code path is used via `ReferenceStateWrapper`. This change surfaces the `textBreakStrategy` and `justificationMode` values already computed in `TextLayoutManager.createLayout()` by: - Introducing a `CreateLayoutResult` wrapper to return them alongside the `Layout` - Adding both fields to `PreparedLayout` - Propagating them through `FabricUIManager.reusePreparedLayoutWithNewReactTags()` - Using the real values in `ReactTextViewManager.getReactTextUpdateFromPreparedLayout()` Changelog: [Internal] Differential Revision: D93933310
meta-cla
bot
added
the
CLA Signed
|
@NickGerleman has exported this pull request. If you are a Meta employee, you can view the originating Diff in D93933310. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
getReactTextUpdateFromPreparedLayout()hardcodedtextBreakStrategytoBREAK_STRATEGY_HIGH_QUALITYandjustificationModeto0, causinguser-specified values like
textBreakStrategy: "simple"ortextAlign: "justify"to be ignored when the PreparedLayout code pathis used via
ReferenceStateWrapper.This change surfaces the
textBreakStrategyandjustificationModevalues already computed in
TextLayoutManager.createLayout()by:CreateLayoutResultwrapper to return them alongside theLayoutPreparedLayoutFabricUIManager.reusePreparedLayoutWithNewReactTags()ReactTextViewManager.getReactTextUpdateFromPreparedLayout()Changelog: [Internal]
Differential Revision: D93933310