Stub UIViewOperationQueue and remove its usages#55658
Closed
mdvacca wants to merge 2 commits intofacebook:mainfrom
Closed
Stub UIViewOperationQueue and remove its usages#55658mdvacca wants to merge 2 commits intofacebook:mainfrom
mdvacca wants to merge 2 commits intofacebook:mainfrom
Conversation
Summary: Remove the NativeViewHierarchyOptimizer class and all its usages. This class was part of the Legacy Architecture and had already been largely gutted (most logic removed due to NativeKind removal). Its remaining responsibilities have been inlined into the call sites: UIImplementation now directly enqueues view operations on UIViewOperationQueue, and ReactShadowNodeImpl.dispatchUpdates now directly calls enqueueUpdateLayout. The NativeViewHierarchyOptimizer parameter has been removed from the ReactShadowNode.onBeforeLayout() and dispatchUpdates() interfaces. changelog: [internal] internal Reviewed By: NickGerleman Differential Revision: D93037023
Summary: UIViewOperationQueue is part of the Legacy Architecture and is no longer needed. This change stubs out all methods in the class (making them no-ops) and removes all call sites that invoked those methods across the codebase. Specifically: - UIViewOperationQueue: All method bodies replaced with empty stubs, all inner classes removed, all fields removed. The public API signatures are preserved for backward compatibility. - UIImplementation: All calls to mOperationsQueue.enqueue*, dispatchViewUpdates, resumeFrameCallback, pauseFrameCallback, etc. removed. Layout update listener is now called directly instead of through the queue. - UIManagerModule: resolveView() now returns null instead of chaining through the operation queue. - ReactShadowNodeImpl: dispatchUpdates() no longer calls enqueueUpdateLayout on the operation queue. - ARTSurfaceViewShadowNode: Deleted the onCollectExtraUpdates override that called enqueueUpdateExtraData. Reviewed By: NickGerleman Differential Revision: D93069524
meta-cla
bot
added
the
CLA Signed
|
This pull request has been merged in 7de3dbe. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
UIViewOperationQueue is part of the Legacy Architecture and is no longer needed. This change stubs out all methods in the class (making them no-ops) and removes all call sites that invoked those methods across the codebase.
Specifically:
Reviewed By: NickGerleman
Differential Revision: D93069524