Skip to content

Add Intersection Observer E2E tests for FB #55656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lunaleaps wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add Intersection Observer E2E tests for FB #55656

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
117 changes: 55 additions & 62 deletions packages/rn-tester/js/examples/IntersectionObserver/IntersectionObserverClippingParent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,55 +15,41 @@ import type IntersectionObserverEntry from 'react-native/src/private/webapis/int
import * as React from 'react';
import {useCallback, useLayoutEffect, useRef, useState} from 'react';
import {Button, StyleSheet, Text, TextInput, View} from 'react-native';
import DOMRectReadOnly from 'react-native/src/private/webapis/geometry/DOMRectReadOnly';

export const name = 'IntersectionObserver Parent Clipping Example';
export const title = name;
export const description = 'A clipping parent clips both the root and target';

declare var IntersectionObserver: Class<IntersectionObserverType>;

export function render(): React.Node {
return <IntersectionObserverCustomClippingRootExample />;
export function render(options?: {e2eTest?: boolean}): React.Node {
return (
<IntersectionObserverCustomClippingRootExample
e2eTest={options?.e2eTest ?? false}
/>
);
}

/**
* Showcase threshold of two overlapping elements
* Formats a DOMRectReadOnly for display with a label.
*/
function roundRect(rect: unknown): ?{
x: number,
y: number,
width: number,
height: number,
} {
function formatRect(label: string, rect: ?DOMRectReadOnly): ?string {
if (rect == null || typeof rect !== 'object') {
return null;
}
// $FlowFixMe[prop-missing]
const x = rect.x;
// $FlowFixMe[prop-missing]
const y = rect.y;
// $FlowFixMe[prop-missing]
const width = rect.width;
// $FlowFixMe[prop-missing]
const height = rect.height;

if (
typeof x !== 'number' ||
typeof y !== 'number' ||
typeof width !== 'number' ||
typeof height !== 'number'
) {
if (typeof width !== 'number' || typeof height !== 'number') {
return null;
}
return {
x: Math.round(x),
y: Math.round(y),
width: Math.round(width),
height: Math.round(height),
};
return `${label}: width:${Math.round(width)}, height:${Math.round(height)}`;
}

component IntersectionObserverCustomClippingRootExample() {
component IntersectionObserverCustomClippingRootExample(
e2eTest: boolean = false,
) {
const rootRef = useRef<?HostInstance>(null);
const targetRef = useRef<?HostInstance>(null);
const [intersectionEntry, setIntersectionEntry] =
Expand Down Expand Up @@ -136,35 +122,39 @@ component IntersectionObserverCustomClippingRootExample() {
<Text style={styles.currentMargin}>
Current Root Margin: {rootMarginValue}
</Text>
<Text style={styles.description}>
This example highlights a clipping parent to both the explicit root
(blue) and target (yellow). The dashed borders show the full extent of
the root and target, while the solid colors show what's actually visible
after clipping. The purple dashed border shows the root bounds after
applying rootMargin.
</Text>
<View style={styles.legend}>
<View style={styles.legendItem}>
<View style={[styles.legendBox, styles.legendClipping]} />
<Text style={styles.legendText}>Clipping Area (100x100)</Text>
</View>
<View style={styles.legendItem}>
<View style={[styles.legendBox, styles.legendRoot]} />
<Text style={styles.legendText}>Root (visible)</Text>
</View>
<View style={styles.legendItem}>
<View style={[styles.legendBox, styles.legendTarget]} />
<Text style={styles.legendText}>Target (visible)</Text>
</View>
<View style={styles.legendItem}>
<View style={[styles.legendBox, styles.legendIndicator]} />
<Text style={styles.legendText}>Full extent (dashed)</Text>
</View>
<View style={styles.legendItem}>
<View style={[styles.legendBox, styles.legendRootMargin]} />
<Text style={styles.legendText}>Root + Margin (purple)</Text>
{!e2eTest && (
<Text style={styles.description}>
This example highlights a clipping parent to both the explicit root
(blue) and target (yellow). The dashed borders show the full extent of
the root and target, while the solid colors show what's actually
visible after clipping. The purple dashed border shows the root bounds
after applying rootMargin.
</Text>
)}
{!e2eTest && (
<View style={styles.legend}>
<View style={styles.legendItem}>
<View style={[styles.legendBox, styles.legendClipping]} />
<Text style={styles.legendText}>Clipping Area (100x100)</Text>
</View>
<View style={styles.legendItem}>
<View style={[styles.legendBox, styles.legendRoot]} />
<Text style={styles.legendText}>Root (visible)</Text>
</View>
<View style={styles.legendItem}>
<View style={[styles.legendBox, styles.legendTarget]} />
<Text style={styles.legendText}>Target (visible)</Text>
</View>
<View style={styles.legendItem}>
<View style={[styles.legendBox, styles.legendIndicator]} />
<Text style={styles.legendText}>Full extent (dashed)</Text>
</View>
<View style={styles.legendItem}>
<View style={[styles.legendBox, styles.legendRootMargin]} />
<Text style={styles.legendText}>Root + Margin (purple)</Text>
</View>
</View>
</View>
)}
<View style={styles.visualizationContainer}>
<View style={styles.clippingParent}>
<View ref={rootRef} style={styles.root}>
Expand Down Expand Up @@ -214,16 +204,19 @@ component IntersectionObserverCustomClippingRootExample() {
{(intersectionEntry.intersectionRatio * 100).toFixed(1)}%
</Text>
<Text style={styles.metric}>
Intersection Rect:{' '}
{JSON.stringify(roundRect(intersectionEntry.intersectionRect))}
{formatRect(
'Intersection Rect',
intersectionEntry.intersectionRect,
)}
</Text>
<Text style={styles.metric}>
Bounding Client Rect:{' '}
{JSON.stringify(roundRect(intersectionEntry.boundingClientRect))}
{formatRect(
'Bounding Client Rect',
intersectionEntry.boundingClientRect,
)}
</Text>
<Text style={styles.metric}>
Root Bounds:{' '}
{JSON.stringify(roundRect(intersectionEntry.rootBounds))}
{formatRect('Root Bounds', intersectionEntry.rootBounds)}
</Text>
</View>
)}
Expand Down
7 changes: 7 additions & 0 deletions ...ages/rn-tester/js/examples/IntersectionObserver/IntersectionObserverExplicitRootScroll.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ component IntersectionObserverExplicitRootScrollExample() {
}}
ref={roofRef}>
<Button
testID="toggle_margin"
title={`Click to ${showMargin ? 'remove' : 'add'} margin`}
onPress={() => {
setShowMargin(show => !show);
Expand Down Expand Up @@ -148,6 +149,12 @@ function ListItem(props: {
props.style,
]}
ref={itemRef}>
{intersectionRatio >= props.threshold ? (
<Text>Intersecting by threshold</Text>
) : null}
{intersectionRootRatio >= (props.rootThreshold ?? 1) ? (
<Text>Intersecting by rootThreshold</Text>
) : null}
<Text style={styles.description}>{props.description}</Text>
{props.rootThreshold != null && (
<Text>rootThreshold: {props.rootThreshold}</Text>
Expand Down
Loading