Skip to content

Disable inapplicable commands for React Native targets#251

Merged
huntie merged 1 commit intofacebook:mainfrom
huntie:disable-misc-commands
Apr 20, 2026
Merged

Disable inapplicable commands for React Native targets#251
huntie merged 1 commit intofacebook:mainfrom
huntie:disable-misc-commands

Conversation

@huntie
Copy link
Copy Markdown
Member

@huntie huntie commented Apr 20, 2026

Summary

Gate additional commands and settings behind the NOT_REACT_NATIVE_SPECIFIC_UI experiment, hiding them when REACT_NATIVE_SPECIFIC_UI is enabled. These commands don't apply to React Native debugging targets.

Disabled commands:

  • ALL "Rendering" commands
  • Performance > "Start instrumenting coverage and reload page"
  • Network > "Go offline"/"Go online"
  • Network > all enable/disable throttling and cache
  • ALL "Mobile" commands
  • ALL "Grid" commands
  • "Undock into separate window"
  • "Restore last dock position"
  • Elements > "Show rulers on hover"
  • Debugger > "Disable JavaScript"

Test plan

Header Header
image image
❌ A number of commands that aren't implemented by RN are available ✅ Commands disabled

Upstreaming plan

@huntie huntie requested review from emily8rown, hoxyq and motiz88 April 20, 2026 13:22
@meta-cla meta-cla Bot added the cla signed label Apr 20, 2026
@huntie huntie force-pushed the disable-misc-commands branch from 016f3a4 to 19dbc9e Compare April 20, 2026 13:24
@huntie huntie marked this pull request as ready for review April 20, 2026 13:25
Copy link
Copy Markdown

@motiz88 motiz88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Collect garbage

That should be supported, I think and should be trivial to fix on the RN side if something isn't working. Could you look into that? Other than that, LGTM.

Gate additional commands and settings behind the `NOT_REACT_NATIVE_SPECIFIC_UI` experiment, hiding them when REACT_NATIVE_SPECIFIC_UI is enabled. These commands don't apply to React Native debugging targets.

Disabled commands:
- ALL "Rendering" commands
- Performance > "Start instrumenting coverage and reload page"
- Performance > "Collect garbage"
- Network > "Go offline"/"Go online"
- Network > all enable/disable throttling and cache
- ALL "Mobile" commands
- ALL "Grid" commands
- "Undock into separate window"
- "Restore last dock position"
- Elements > "Show rulers on hover"
- Debugger > "Disable JavaScript"
@huntie huntie force-pushed the disable-misc-commands branch from 19dbc9e to b3406d8 Compare April 20, 2026 13:38
@huntie huntie merged commit af53aca into facebook:main Apr 20, 2026
5 checks passed
@huntie huntie deleted the disable-misc-commands branch April 20, 2026 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants