fix: support ConstExpr with functions defined via expr.Function#955
Open
Yanhu007 wants to merge 1 commit intoexpr-lang:masterfrom
Open
fix: support ConstExpr with functions defined via expr.Function#955Yanhu007 wants to merge 1 commit intoexpr-lang:masterfrom
Yanhu007 wants to merge 1 commit intoexpr-lang:masterfrom
Conversation
ConstExpr panics when the named function was defined using expr.Function() instead of being a method on the environment struct. This is because ConstExpr only looks in the environment object via runtime.Fetch, not in the Functions table. Check c.Functions first and extract the appropriate function implementation (Func, Fast, or Safe) before falling back to the environment object lookup. Fixes expr-lang#809
Member
|
Could you please also add a test to cover this API usage? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #809
Problem
expr.ConstExpr("fn")panics whenfnwas defined usingexpr.Function()instead of being a method on the environment struct:This is because
ConstExpronly looks in the environment object viaruntime.Fetch, not in theFunctionstable populated byexpr.Function().Fix
Check
c.Functionsfirst and extract the appropriate function implementation (Func,Fast, orSafe) before falling back to the environment object lookup.