Conversation
|
Thanks for submitting your first pull request! You are awesome! 🤗 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #258 +/- ##
=======================================
Coverage 96.07% 96.07%
=======================================
Files 62 62
Lines 3236 3236
=======================================
Hits 3109 3109
Misses 127 127
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hukkin
left a comment
There was a problem hiding this comment.
This should work, although my opinion is that support for alpha/beta releases should not be expected, so perhaps not worth it to further complicate the tuple comparison with non-integer values?
Co-authored-by: Taneli Hukkinen <3275109+hukkin@users.noreply.github.com>
I agree with the principle, but in this case I feel that the extra code is not that much more complex to justify not making this change? I'll defer to your final judgement though — merge this if you're happy, close if not! :) |
I didn't bisect to find when 3.10 adds the
slotsargument; I know it's in the release itself, and I don't think we need to be that careful to provide features to old alpha/beta/rc releases.