Skip to content

#725: Added newline after headlines for dependency changes #726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ckunki merged 1 commit into from
Feb 25, 2026
Merged

#725: Added newline after headlines for dependency changes #726

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/changes/unreleased.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
* #714: Added logic to modify a workflow using the .workflow-patcher.yml
* #717: Restricted workflow names in .workflow-patcher.yml to template workflow names
* #719: Added nox session `workflow:generate` to generate/update workflows using the `.workflow-patcher.yml` (if desired)
* #725: Added newline after headlines for dependency changes

## Documentation

Expand Down
2 changes: 1 addition & 1 deletion exasol/toolbox/util/release/changelog.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ def _describe_dependency_changes(self) -> str:
).changes
if changes:
changes_str = "\n".join(str(change) for change in changes)
changes_by_group.append(f"\n### `{group}`\n{changes_str}\n")
changes_by_group.append(f"\n### `{group}`\n\n{changes_str}\n")
return "".join(changes_by_group)

@staticmethod
Expand Down
10 changes: 6 additions & 4 deletions test/unit/util/release/changelog_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,10 +151,10 @@ def test_describe_dependency_changes(changelogs, mock_dependencies):
result = changelogs._describe_dependency_changes()
assert result == (
"\n"
"### `main`\n"
"### `main`\n\n"
"* Updated dependency `package1:0.0.1` to `0.1.0`\n"
"\n"
"### `dev`\n"
"### `dev`\n\n"
"* Added dependency `package2:0.2.0`\n"
)

Expand All @@ -165,10 +165,10 @@ def test_describe_dependency_changes_without_latest_version(
result = changelogs._describe_dependency_changes()
assert result == (
"\n"
"### `main`\n"
"### `main`\n\n"
"* Added dependency `package1:0.1.0`\n"
"\n"
"### `dev`\n"
"### `dev`\n\n"
"* Added dependency `package2:0.2.0`\n"
)

Expand Down Expand Up @@ -227,9 +227,11 @@ def test_update_changelogs_for_release(
## Dependency Updates

### `main`

* Updated dependency `package1:0.0.1` to `0.1.0`

### `dev`

* Added dependency `package2:0.2.0`
"""
)
Expand Down