Fix pods and runner api not in sync and other improvments#496
Open
hybner wants to merge 3 commits intoevryfs:masterfrom
Open
Fix pods and runner api not in sync and other improvments#496hybner wants to merge 3 commits intoevryfs:masterfrom
hybner wants to merge 3 commits intoevryfs:masterfrom
Conversation
added 3 commits
October 3, 2022 15:46
When pods are deleted then podRunnerPairs should be reloaded, so it's better to requeue reconcilation immediately. When new pods are scale up then it takes some time usually a few seconds to sync between pods and runner API and so there is no need to wait whole period (default 1m) to sync. Signed-off-by: Lukas Hybner <git@hybner.net>
We use ephemeral runners which shutdown after pipeline ends and after this new runners starts. So I change behaviour to scale up new runners when idle runners change to busy. This is change meaning minRunners property to mininum idle Runners. This change respect maxRunners property. Signed-off-by: Lukas Hybner <git@hybner.net>
Signed-off-by: Lukas Hybner <git@hybner.net>
hybner
force-pushed
the
fix/podsAndRunnerApiNotInSync
branch
from
57d5dd6 to
5f7beae
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #496 +/- ##
==========================================
- Coverage 64.22% 63.13% -1.09%
==========================================
Files 3 3
Lines 313 320 +7
==========================================
+ Hits 201 202 +1
- Misses 86 91 +5
- Partials 26 27 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
@davidkarlsen Is it possible to merge this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix reconcilation when pods was deleted.
When pods are deleted then podRunnerPairs should be reloaded, so it's
better to requeue reconcilation immediately.
When new pods are scale up then it takes some time usually a few seconds
to sync between pods and runner API and so there is no need to wait
whole period (default 1m) to sync.
Better scale up and down runners
We use ephemeral runners which shutdown after pipeline ends and after
this new runners starts. So I change behaviour to scale up new runners
when idle runners change to busy. This is change meaning minRunners
property to mininum idle Runners. This change respect maxRunners
property.