Add referer header to Nominatim requests (v4)#416
Open
bplubell wants to merge 2 commits intoethercreative:v4from
Open
Add referer header to Nominatim requests (v4)#416bplubell wants to merge 2 commits intoethercreative:v4from
bplubell wants to merge 2 commits intoethercreative:v4from
Conversation
Per the [Nominatim usage policy][1], all requests should have an identifying Referer or User-Agent header (quoted below). Using the host name, as we already do for Mapbox requests, should be sufficient to satisfy the requirement while avoiding the need for additional settings. > Provide a valid HTTP Referer or User-Agent identifying the > application (stock User-Agents as set by http libraries will not do). [1]: https://operations.osmfoundation.org/policies/nominatim/
An openstreetmap.org system administrator recommended we include an app identifier in the User-Agent header. My inference is that they block based on the User-Agent. However, I did not want to use only the app identifier so I found the form that Craft uses and copied that, appending the app identifier.
bplubell
force-pushed
the
v4-nominatim-referer-header
branch
from
aa6f7ea to
a48b80d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per the Nominatim usage policy, all requests should have an identifying Referer or User-Agent header (quoted below). Using the host name, as we already do for Mapbox requests, should be sufficient to satisfy the requirement while avoiding the need for additional settings.
Based on a recommendation from an openstreetmap.org system administrator, I also added the identifier to the User-Agent header. My inference was that they block requests using it and having an app identifier would make it less likely we are blocked by another user that happens to be using the same User-Agent.