Keep npm start tests self-contained for playground#9
Merged
Conversation
Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npm start --silentrunner in each affected expression/output solution testrun-npm-start.tshelper so copied playground tests do not import files outside the playgroundshell: truebehavior across platformsWhy
epicshop/post-set-playground.jscopies only*.test.tsfiles from the solution directory into the flat playground directory. Keeping the runner in a sibling helper means playground tests can fail with a missing../run-npm-start.tsimport.Verification
PATH="/home/ubuntu/.nvm/versions/node/v22.18.0/bin:$PATH"; node -v && npm run typecheck && node ./epicshop/test.js ..sAll 26 solution test suites passed. Problem test suites were not included.