Skip to content

Quipu Rojo#2473

Draft
kevinKVN00 wants to merge 33 commits into
endlessm:mainfrom
GameLab6-UTP-Grupo5-Equipo5:main
Draft

Quipu Rojo#2473
kevinKVN00 wants to merge 33 commits into
endlessm:mainfrom
GameLab6-UTP-Grupo5-Equipo5:main

Conversation

@kevinKVN00

Copy link
Copy Markdown

No description provided.

kevinKVN00 and others added 30 commits May 25, 2026 18:03
Duplicate and rename template and all files
…uendia1y

Minijuego 3 jugable y con mecánica
…mites

Se modificó del temporizador, audio, terreno y se limitó el area del mapa
…x-dependencias

Restauración de los archivos de la carpeta elementos del minijuego 3
@kevinKVN00 kevinKVN00 requested a review from a team as a code owner June 24, 2026 22:31
@manuq

manuq commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

@kevinKVN00 ¡hola!

Por favor revisen https://github.com/endlessm/threadbare/wiki/StoryQuest-submission y marquen esto como "ready for review" cuando esté listo!
/
Please review https://github.com/endlessm/threadbare/wiki/StoryQuest-submission and mark this as ready for review when ready!

@manuq manuq marked this pull request as draft June 25, 2026 00:06
@github-actions

Copy link
Copy Markdown

Play this branch at https://play.threadbare.game/branches/GameLab6-UTP-Grupo5-Equipo5/main/.

(This launches the game from the start, not directly at the change(s) in this pull request.)

@wjt wjt added the StoryQuest New StoryQuests or updates to existing ones label Jun 25, 2026
@kevinKVN00 kevinKVN00 marked this pull request as ready for review June 26, 2026 18:18
@manuq manuq assigned manuq and unassigned manuq Jul 7, 2026
@manuq manuq marked this pull request as draft July 7, 2026 19:43
@wjt wjt self-assigned this Jul 9, 2026

@wjt wjt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice quest! I love how the two stealth stages are quite large, with a complicated maze structure. It makes for a different kind of challenge to a lot of those I've seen before in the game. The flow - stealth, codebreaking, stealth again but this time with time pressure - works well. I also particularly like the enemy art!

I have a number of comments about the level design, some technical points, and licensing questions. Please also review https://github.com/endlessm/threadbare/wiki/StoryQuest-submission.

Please forgive me for writing the whole review in English - I don't speak Spanish. Feel free to ask (here or on discord) if you need more clarification on any of the points here.


[resource]
script = ExtResource("1_bi1xp")
title = "jueguito"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fill in the title, description, authors, etc. for this quest. Right now it looks rather empty in the storybook!

Image

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused copy of assets/third_party/tiny-swords/UI/Banners/Banner_Horizontal.png, please remove.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused, please delete

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused, please delete

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused, please delete


[params]

loop=false

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, one typically wants background music to loop, and to loop cleanl.y

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the timer in this scene: it adds some pressure and fits the plot well!

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused copy of res://assets/third_party/tiny-swords-non-cc0/Terrain/Resources/Wood/Trees/Stump 1.png, please remove, along with 2, 3 and 4.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This (and the image it references) isn't used. Did you intend to use it somewhere in the scene?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The music in this scene is played by an AudioStreamPlayer2D. I can see why you didn't use BackgroundMusic for this - you want the music to start at the same time as the counter. (It is possible to do this - see res://scenes/quests/lore_quests/quest_002/1_void_runner/void_runner.tscn for an example, where the music is an AudioStreamInteractive and transitions between different clips are triggered by Area2Ds in the world. You're welcome to set up the same thing here but you don't have to.)

However AudioStreamPlayer2D is the wrong node to use for background music. It is meant for sounds that exist in the game world, and depending on where the node is relative to the centre of the screen, the audio will be panned and/or attenuated. I can see that you set Max Distance to 24,000px so that it never fades to nothing; but it still pans to the left ear as soon as you run to the right.

Image

Change the node type to AudioStreamPlayer (it has the same API minus the 2D bits). Change the "Bus" to "Music" so that it respects the volume control.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

StoryQuest New StoryQuests or updates to existing ones

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants