Add “Amaruq y El Dorado” StoryQuest#2431
Conversation
…emplate Duplicate and rename template and all files GRUPO 3
cambios de paolo
termino-el-intro-avance-minijuego1
avance-juego-de-memorio-falta
…ueda al pendiente el mini juego 1
seguimos avanzando este commit se continuo con el mini juego 2 pero queda pendiente el juego 1
avance con los guardianes del mini juego 1
quedan 2 cambios
errores resueltos
errores resueltos definitivo
|
Please review https://github.com/endlessm/threadbare/wiki/StoryQuest-submission and mark this as ready for review when ready! |
Logicaprimerminujuego
| func _ready(): | ||
| $AnimationPlayer.play("uno") | ||
| $AnimationPlayer.animation_finished.connect(_on_animation_finished) | ||
|
|
||
| func _on_animation_finished(anim_name): | ||
| $AnimationPlayer.play("uno") |
There was a problem hiding this comment.
You can set the animation as looping instead of doing this by hand.
| extends Area2D | ||
|
|
||
| func _ready(): | ||
| $AnimationPlayer.play("uno") |
There was a problem hiding this comment.
Use AnimationPlayer.autoplay to choose the animation to play automatically. Then you don't need to do this in code, with 3 different copies of the same script just to change the animation name.
|
|
||
| func _on_body_entered(body): | ||
| if body.name == "Player": | ||
| get_tree().reload_current_scene() # reinicia la escena al inicio |
There was a problem hiding this comment.
Use:
SceneSwitcher.reload_with_transition()to get a nice fade-out/fade-in while reloading.
| @tool | ||
| class_name Cinematic | ||
| extends SceneLink | ||
| class_name CasaDeLaChinaCinematic |
There was a problem hiding this comment.
I don't think you meant to change the class_name of the shared cinematic.gd script.
| ## Used from dialogue (do wait_for_walk()) to pause until the current | ||
| ## animation on [member animation_player] finishes playing. | ||
| func wait_for_walk() -> void: | ||
| await animation_player.animation_finished |
There was a problem hiding this comment.
You don't need this. In a .dialogue file you can wait for a signal with:
do animation_player.animation_finished
I did a quick pass over the code; but I'll leave this for now. Please review the submission guidelines, and mark the PR as ready (not draft) when it is ready for another round of review! |
Merliarous cambios musica
Agregando personajes
Muchos cambiios dialogos y colisiones
Ultimos puntos
salvando la llave
4 participants
el primer PR up Stream