ci: Don't double-compress Linux metadata tarball#2023
Merged
Conversation
dependabot
bot
added
dependencies
dependabot
bot
added
dependencies
|
Play this branch at https://play.threadbare.game/branches/endlessm/dependabot/github_actions/github-985357984d. (This launches the game from the start, not directly at the change(s) in this pull request.) |
Member
This is great because we currently upload single files which get zipped. We should adopt this new API as part of this change. |
wjt
changed the title
wjt
force-pushed
the
dependabot/github_actions/github-985357984d
branch
2 times, most recently
from
90ef1d9 to
a7a8905
Compare
wjt
changed the title
actions/upload-artifact@v7 adds the ability to upload a single file without wrapping it in a .zip file. This is useful because we upload a tarball containing the .desktop file, AppStream metainfo file, and icons necessary to build a Linux package for the game as a .tar.gz (because it is ultimately attached to the release, where bare files were already supported). Update actions/upload-artifact from 6 to 7 and actions/download-artifact from 7 to 8. Use the new archive: false parameter. Remove the name: parameter which is documented to be ignored in this mode. While we're here: don't attach the .pck file separately. We are already uploading the web build as a .zip containing the same file. Instead adjust the other steps to fetch it from the web build.
wjt
force-pushed
the
dependabot/github_actions/github-985357984d
branch
from
a7a8905 to
9aecd8f
Compare
wjt
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
actions/upload-artifact@v7 adds the ability to upload a single file
without wrapping it in a .zip file. This is useful because we upload a tarball
containing the .desktop file, AppStream metainfo file, and icons
necessary to build a Linux package for the game as a .tar.gz (because it
is ultimately attached to the release, where bare files were already
supported).
Update actions/upload-artifact from 6 to 7 and actions/download-artifact
from 7 to 8. Use the new archive: false parameter. Remove the name:
parameter which is documented to be ignored in this mode.
While we're here: don't attach the .pck file separately. We are already
uploading the web build as a .zip containing the same file. Instead
adjust the other steps to fetch it from the web build.