Fix: Merge URL query parameters instead of replacing them #3759
+98
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3621
When a URL already contains query parameters and additional
paramsare passed, httpx was dropping the original URL parameters instead of merging them. This was inconsistent with therequestslibrary behavior.Problem
Solution
Modified
URL.__init__()in_urls.pyto:paramsargumentChanges
httpx/_urls.py: Updated param handling to merge instead of replacetests/models/test_url.pyTest Cases
Merge existing and new params:
Override with same key:
Empty params preserves existing:
No existing params works normally:
Testing