fix: Handle unhashable BooleanField representation value#9973
Open
emfpdlzj wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes BooleanField.to_representation() resilient to unhashable values (e.g., [], {}, set()) by suppressing TypeError during membership checks, aligning its behavior with to_internal_value() while preserving the existing bool(value) fallback.
Changes:
- Wrap
BooleanField.to_representation()’s TRUE/FALSE/NULL token membership checks incontextlib.suppress(TypeError). - Update
BooleanFieldoutput tests to use a list of(value, expected)pairs (allowing unhashable test inputs) and add coverage for unhashable collections.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
rest_framework/fields.py |
Suppresses TypeError during set-membership checks in BooleanField.to_representation() so unhashable values fall back to bool(value). |
tests/test_fields.py |
Extends BooleanField representation coverage to include unhashable collections by switching outputs to tuple-pairs and adding new cases. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small consistency fix for
BooleanField.to_representation(), matching the existingTypeErrorhandling used byto_internal_value()while preserving the existingbool(value)fallback.Summary
BooleanField.to_representation()now handles unhashable values consistently withto_internal_value().Previously, values like
[],{}, orset()could raiseTypeErrorduring membership checks before reaching the existingbool(value)fallback. This change suppressesTypeErroraround the explicit true/false/null token checks, allowing unrecognized unhashable values to be represented by their truthiness.Test
uv run --no-project --with 'django==5.2.*' --with 'pytest==9.*' --with pytest-django --with dj-database-url --with importlib-metadata --with pytz -m pytest tests/test_fields.py -k BooleanField