Skip to content

Revert default for GROWABLE_ARRAYBUFFERS to 0#27260

Merged
sbc100 merged 1 commit into
emscripten-core:mainfrom
sbc100:GROWABLE_ARRAYBUFFERS
Jul 6, 2026
Merged

Revert default for GROWABLE_ARRAYBUFFERS to 0#27260
sbc100 merged 1 commit into
emscripten-core:mainfrom
sbc100:GROWABLE_ARRAYBUFFERS

Conversation

@sbc100

@sbc100 sbc100 commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

Split out from #27242.

See: #27241

@sbc100 sbc100 requested a review from kripken July 6, 2026 20:36
@sbc100 sbc100 force-pushed the GROWABLE_ARRAYBUFFERS branch from a87d837 to 44b0b66 Compare July 6, 2026 20:36
@kripken

kripken commented Jul 6, 2026

Copy link
Copy Markdown
Member

Any idea why we missed these issues in our own testing? We check lots of WebGL and other Web APIs, did we just happen to not hit any bad ones?

@sbc100

sbc100 commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator Author

I guess because most of our tests don't use memory growth.

I think the test in #27242 should be enough to cover this.

@kripken

kripken commented Jul 6, 2026

Copy link
Copy Markdown
Member

I see, makes sense.

I wonder if we should add more growth testing? That mode is common enough that it possibly should be the default. If we have very little browser testing of it, that worries me (though maybe not enough for an entire new browser suite).

@sbc100

sbc100 commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator Author

I see, makes sense.

I wonder if we should add more growth testing? That mode is common enough that it possibly should be the default. If we have very little browser testing of it, that worries me (though maybe not enough for an entire new browser suite).

Yes, perhaps we should run the whole core tests with growable memory enabled? Or the entire browser tests suite?

@sbc100 sbc100 force-pushed the GROWABLE_ARRAYBUFFERS branch from 44b0b66 to 6dca87d Compare July 6, 2026 22:37
@kripken

kripken commented Jul 6, 2026

Copy link
Copy Markdown
Member

Browser suite seems better for API coverage - but it also seems excessive. Not sure what's best here.

@sbc100 sbc100 force-pushed the GROWABLE_ARRAYBUFFERS branch from 6dca87d to c6c1999 Compare July 6, 2026 23:28
@sbc100 sbc100 merged commit cd9990f into emscripten-core:main Jul 6, 2026
3 of 19 checks passed
@sbc100 sbc100 deleted the GROWABLE_ARRAYBUFFERS branch July 6, 2026 23:28
cyderize added a commit to MiniZinc/minizinc-js that referenced this pull request Jul 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants