Revert default for GROWABLE_ARRAYBUFFERS to 0#27260
Conversation
a87d837 to
44b0b66
Compare
|
Any idea why we missed these issues in our own testing? We check lots of WebGL and other Web APIs, did we just happen to not hit any bad ones? |
|
I guess because most of our tests don't use memory growth. I think the test in #27242 should be enough to cover this. |
|
I see, makes sense. I wonder if we should add more growth testing? That mode is common enough that it possibly should be the default. If we have very little browser testing of it, that worries me (though maybe not enough for an entire new browser suite). |
Yes, perhaps we should run the whole core tests with growable memory enabled? Or the entire browser tests suite? |
44b0b66 to
6dca87d
Compare
|
Browser suite seems better for API coverage - but it also seems excessive. Not sure what's best here. |
Split out from emscripten-core#27242. See: emscripten-core#27241
6dca87d to
c6c1999
Compare
Needed until emscripten-core/emscripten#27260 lands in a release
Split out from #27242.
See: #27241