run_python.sh: Add readlink to allow symlinks to compiler entry points to work correctly#27220
Open
kapouer wants to merge 1 commit into
Open
run_python.sh: Add readlink to allow symlinks to compiler entry points to work correctly#27220kapouer wants to merge 1 commit into
readlink to allow symlinks to compiler entry points to work correctly#27220kapouer wants to merge 1 commit into
Conversation
Collaborator
|
I updated the PR description, please can you check that I got that it right? |
readlink to allow symlinks to compiler entry points to work correctly
Collaborator
|
(also updated the title.. again, please check I'm correct) |
Collaborator
|
It looks like there are a couple of valid failures on the arm64 macos bot: |
Collaborator
|
Ah, the problem is the According to Gemini: If the goal is to allow $0 to be executed via a symlink (e.g., from /usr/local/bin/emprofile ), the standard POSIX / macOS-safe way |
sbc100
reviewed
Jun 30, 2026
| exit 1 | ||
| fi | ||
|
|
||
| exec "$_EM_PY" -E "$0.py" "$@" |
Collaborator
There was a problem hiding this comment.
You also need to update tools/maint/run_python_compiler.sh I think
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows symbol links to the the compiler to work. Without this change, if you have for example
/usr/bin/emccas a symlink for/usr/local/share/emscripten/emccthen it would not work.Fixes: #27211