Allow environment variables in config strings. NFC#27215
Open
sbc100 wants to merge 1 commit into
Open
Conversation
sbc100
force-pushed
the
config_vars_expand
branch
3 times, most recently
from
bd44323 to
830e0a5
Compare
sbc100
changed the title
This allows us to avoid doing things like `os.path.expanduser` and `os.path.expandvars` inside the config files themselves. This should help pave the way to one day making the config files plain text rather than python scripts. See emscripten-core#27219
sbc100
force-pushed
the
config_vars_expand
branch
from
830e0a5 to
88e1a2a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows us to avoid doing things like
os.path.expanduserandos.path.expandvarsinside the config files themselves.This should help pave the way to one day making the config files plain
text rather than python scripts.
See #27219