Add openmp library from llvm#27073
Conversation
|
Thanks a lot for looking into this. I'm looking forward to this for supporting openmp with clang-repl in the browser ! |
|
@anutosh491 tests are resolved. But I haven't tried it on my app yet. |
|
hi, @JAicewizard have you taken a look yet? |
duerrbaby
changed the title
|
@sbc100 can you help to review? |
|
@JAicewizard @sbc100 Hi again, does anyone have the time to review and hopefully merge this? |
sbc100
left a comment
sbc100
left a comment
There was a problem hiding this comment.
Can we call the new directory system/lib/openmp to maybe the llvm directory name?
Can you update the PR title to better reflect what this is? Something like "Add openmp library from llvm" maybe?
| copy_tree(upstream_runtime_root, local_src) | ||
| copy_tree(upstream_inc, local_inc) | ||
|
|
||
| build_dir = os.path.join(upstream_root, "build") |
There was a problem hiding this comment.
Can you use emscripten/out/ for the build direcotroy?
Maybe something like emscripten/out/build_opemmp ?
(so we don't end up writing to the llvm checkout)
| upstream_root = os.path.join(llvm_dir, "openmp/") | ||
| upstream_runtime_root = os.path.join(upstream_root, "runtime/src") | ||
| upstream_inc = os.path.join(upstream_root, "install/usr/include") | ||
| upstream_build_src = os.path.join(upstream_root, "build/runtime/src") |
There was a problem hiding this comment.
Can you set build_dir and install_dir to the build and install directories respectively (and use out/ subdirectores for both).
4 participants
Original PR here: #25937