Simplify pthread ref/unref handling. NFC#26939
Merged
Merged
Conversation
tlively
reviewed
May 13, 2026
We don't need/want threads to be `unref` until the worker is up and running. This is important for emscripten-core#26933 since otherwise the node runtime can shut down while a thread is starting up. This change also simplifies the code by limiting the number of places we called `unref` to just one, which also slightly reduces codesize. Also, remove unused `worker.loaded` assignment. Split out from emscripten-core#26933
tlively
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't need/want threads to be
unrefuntil the worker is up andrunning. This is important for #26933 since otherwise the node runtime
can shut down while a thread is starting up.
This change also simplifies the code by limiting the number of places we called
unrefto just one, which also slightly reduces codesize.Also, remove unused
worker.loadedassignment.Split out from #26933