Skip to content

Enabled test_pthread_dylink_tls under STACK_OVERFLOW_CHECK=2 #26890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sbc100 wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −3
Open

Enabled test_pthread_dylink_tls under STACK_OVERFLOW_CHECK=2 #26890

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -710,6 +710,7 @@ jobs:
core2g.test_externref
corez.test_dylink_iostream
core2ss.test_pthread_dylink
core2ss.test_pthread_dylink_tls
core2ss.test_pthread_thread_local_storage
core2ss.test_wasm_worker_futex_wait
core2s.test_dylink_syslibs_missing_assertions
Expand Down
3 changes: 0 additions & 3 deletions test/test_core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9364,9 +9364,6 @@ def test_pthread_dlsym(self):
@needs_dylink
@requires_pthreads
def test_pthread_dylink_tls(self):
if self.get_setting('STACK_OVERFLOW_CHECK') == 2:
self.skipTest('https://github.com/emscripten-core/emscripten/issues/24964: fails with stack overflow (Attempt to set SP to 0x000114d0, with stack limits [0x00000000 - 0x00000000])')

self.cflags += ['-Wno-experimental', '-pthread']
main = test_file('core/pthread/test_pthread_dylink_tls.c')
self.dylink_testf(main, main_cflags=['-sPTHREAD_POOL_SIZE=1'])
Expand Down
Loading