Skip to content

Require names when using STACK_OVERFLOW_CHECK=2 #26878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbc100 merged 1 commit into from
May 7, 2026
Merged

Require names when using STACK_OVERFLOW_CHECK=2 #26878

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions test/test_other.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3192,6 +3192,7 @@ def test_dwarf_sourcemap_names(self):
(['-Oz', '-gsource-map'], False, True, False),
(['-gsource-map', '-sERROR_ON_WASM_CHANGES_AFTER_LINK'], False, True, False),
(['-gsource-map', '-Og', '-sERROR_ON_WASM_CHANGES_AFTER_LINK'], False, True, False),
(['-sSTACK_OVERFLOW_CHECK=2'], False, False, False),
]:
print(flags, expect_dwarf, expect_sourcemap, expect_names)
self.emcc(test_file(source_file), flags + ['-o', js_file])
Expand Down
2 changes: 2 additions & 0 deletions tools/emscripten.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -541,7 +541,9 @@ def finalize_wasm(infile, outfile, js_syms):
args.append('--side-module')
if settings.STACK_OVERFLOW_CHECK >= 2:
args.append('--check-stack-overflow')
# The check-stack pass in binaryen needs to be able to locate `__stack_pointer` by name.
modify_wasm = True
need_name_section = True
Comment thread
sbc100 marked this conversation as resolved.
if settings.STANDALONE_WASM:
args.append('--standalone-wasm')

Expand Down
Loading