Disable filesystem tests that need a blocking select/poll, which is not yet implemented in WASMFS#26792
Merged
juj merged 1 commit intoemscripten-core:mainfrom Apr 26, 2026
Conversation
sbc100
approved these changes
Apr 26, 2026
| self.do_core_test('test_syscall_intercept.c') | ||
|
|
||
| @requires_pthreads | ||
| @no_wasmfs('TODO: WASMFS does not support a blocking select/poll. https://github.com/emscripten-core/emscripten/issues/26736') |
Collaborator
There was a problem hiding this comment.
The convention is just to include the but URL, rather than duplicating the description too.
juj
force-pushed
the
disable_blocking_select_wasmfs
branch
from
49faa7d to
4705796
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disable filesystem tests that need a blocking select/poll, which is not yet implemented in WASMFS.
emscripten/system/lib/wasmfs/syscalls.cpp
Lines 1433 to 1436 in c113141
#26736