Fix emrun.test_no_browser to launch a browser using the BrowserCore harness#26789
Fix emrun.test_no_browser to launch a browser using the BrowserCore harness#26789juj wants to merge 1 commit intoemscripten-core:mainfrom
Conversation
…arness, so that Firefox/Chrome/Safari will be launched with the appropriate startup flags (and not e.g. try to autoupdate, or show modal user prompts during the test run)
|
Can you try re-enabling these tests first? See #26790 (comment) |
|
Here's a run of emrun suite on Linux and macOS: http://clbri.com:8010/#/builders/11/builds/1479 http://clbri.com:8010/#/builders/13/builds/325 The emrun suite passes after these fixes. I don't think we want to enable red tests on CircleCI, but first fix, and then enable? |
|
I would hope we can enable them at the same time as fixing them. |
| browser = subprocess.Popen(browser_cmd + ['http://localhost:3333/hello_world.html']) | ||
| url = 'http://localhost:3333/hello_world.html?argv0' | ||
| print(f'Starting browser to {url}') | ||
| BrowserCore.browser_open(url) |
There was a problem hiding this comment.
If this static method useful outside the BrowserCore test class maybe we should move it outside? We already have test/browser_common.py for such things I guess?
Also, I wonder if we should move this whole class out into test_emrun.py?
Neither of these need to be part of this PR, just thoughts out how to improve things going forward.
sbc100
left a comment
sbc100
left a comment
There was a problem hiding this comment.
lgtm, but can we enable at emrun tests in circleci as part of this change?
2 participants
Fix emrun.test_no_browser to launch a browser using the BrowserCore harness, so that Firefox/Chrome/Safari will be launched with the appropriate startup flags (and not e.g. try to autoupdate, or show modal user prompts during the test run)