Remove unused element from pthread struct. NFC#26568
Open
sbc100 wants to merge 1 commit intoemscripten-core:mainfrom
Open
Remove unused element from pthread struct. NFC#26568sbc100 wants to merge 1 commit intoemscripten-core:mainfrom
sbc100 wants to merge 1 commit intoemscripten-core:mainfrom
Conversation
This reduces the memory overhead of a pthread from 124 bytes to 100 bytes (~20%) saving.
Member
|
Is this worth increasing the diff vs. musl? Generally there are not many pthreads, so we are talking dozens of bytes, maybe hundreds? |
Collaborator
Author
I was kind of hoping we could add this struct to the TLS area of Wasm Workers.. so that wasm workers could use pthread_mutex_lock etc. I imagined that @juj would like this to be as small as possible to avoid growing the size of the wasm worker allocations, but maybe ~50 bytes per works is not significant? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reduces the memory overhead of a pthread from 124 bytes to 100 bytes (~20%) saving.
This change was created mostly by Gemini CLI.